You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by coheigea <gi...@git.apache.org> on 2018/02/01 16:19:25 UTC

[GitHub] eagle pull request #982: EAGLE-1079 - Fix checkstyle issues in antlr module

GitHub user coheigea opened a pull request:

    https://github.com/apache/eagle/pull/982

    EAGLE-1079 - Fix checkstyle issues in antlr module

    <!--
    {% comment %}
    Licensed to the Apache Software Foundation (ASF) under one or more
    contributor license agreements.  See the NOTICE file distributed with
    this work for additional information regarding copyright ownership.
    The ASF licenses this file to you under the Apache License, Version 2.0
    (the "License"); you may not use this file except in compliance with
    the License.  You may obtain a copy of the License at
    
    http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
    {% endcomment %}
    -->
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[EAGLE-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/coheigea/eagle EAGLE-1079

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/eagle/pull/982.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #982
    
----
commit ff807084e963fde65285e60a48dfb764012c3f8f
Author: Colm O hEigeartaigh <co...@...>
Date:   2018-02-01T16:18:31Z

    EAGLE-1079 - Fix checkstyle issues in antlr module

----


---

[GitHub] eagle pull request #982: EAGLE-1079 - Fix checkstyle issues in antlr module

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/eagle/pull/982


---

[GitHub] eagle issue #982: EAGLE-1079 - Fix checkstyle issues in antlr module

Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the issue:

    https://github.com/apache/eagle/pull/982
  
    LGTM, thanks for fixing style check


---