You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mice xia <mi...@tcloudcomputing.com> on 2013/05/02 07:12:44 UTC
Re: Review Request: fix bug CLOUDSTACK-2160: add a huge size guest network
will cause out of memory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10750/#review20048
-----------------------------------------------------------
Ship it!
Ship It!
- mice xia
On April 24, 2013, 4:20 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10750/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 4:20 a.m.)
>
>
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice xia.
>
>
> Description
> -------
>
> fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of memory
>
> modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 unused ips.
>
>
> This addresses bug CLOUDSTACK-2160.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkModelImpl.java c5930d9
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
> utils/src/com/cloud/utils/net/NetUtils.java 5988dd5
>
> Diff: https://reviews.apache.org/r/10750/diff/
>
>
> Testing
> -------
>
> create a new network with netmask 255.0.0.0 and it won't cause out of memory
>
>
> Thanks,
>
> Hongtu Zang
>
>