You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/08/11 16:23:47 UTC
[Impala-ASF-CR] IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18832
Change subject: IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
......................................................................
IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
Curl changed behaviors in 7.64.0. Previously, it would attempt
to connect without authentication, and for the SPNEGO test,
this would result in a failed attempt. Starting in Curl 7.64,
there is no attempt without authentication, so the count of
failed attempts is one less.
This detects whether the curl version is 7.64.0 or above
and adjusts the count of failed attempts accordingly.
Testing:
- Ran Webserver.TestWithSpnego on Ubuntu 20 (curl version 7.68)
- Ran Webserver.TestWithSpnego on Ubuntu 16 (curl version 7.47)
Change-Id: Icc9b92b334f878792ee649dafa30aed617e55589
---
M be/src/util/webserver-test.cc
1 file changed, 29 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/18832/1
--
To view, visit http://gerrit.cloudera.org:8080/18832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc9b92b334f878792ee649dafa30aed617e55589
Gerrit-Change-Number: 18832
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18832 )
Change subject: IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
......................................................................
IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
Curl changed behaviors in 7.64.0. Previously, it would attempt
to connect without authentication, and for the SPNEGO test,
this would result in a failed attempt. Starting in Curl 7.64,
there is no attempt without authentication, so the count of
failed attempts is one less.
This detects whether the curl version is 7.64.0 or above
and adjusts the count of failed attempts accordingly.
Testing:
- Ran Webserver.TestWithSpnego on Ubuntu 20 (curl version 7.68)
- Ran Webserver.TestWithSpnego on Ubuntu 16 (curl version 7.47)
Change-Id: Icc9b92b334f878792ee649dafa30aed617e55589
Reviewed-on: http://gerrit.cloudera.org:8080/18832
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
---
M be/src/util/webserver-test.cc
1 file changed, 29 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Wenzhe Zhou: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc9b92b334f878792ee649dafa30aed617e55589
Gerrit-Change-Number: 18832
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18832 )
Change subject: IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9b92b334f878792ee649dafa30aed617e55589
Gerrit-Change-Number: 18832
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 20:18:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18832 )
Change subject: IMPALA-11250: Adapt Webserver.TestWithSpnego for curl >= 7.64.0
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11146/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9b92b334f878792ee649dafa30aed617e55589
Gerrit-Change-Number: 18832
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 16:40:28 +0000
Gerrit-HasComments: No