You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/07/12 17:46:31 UTC
[PR] Remove type ignore across codebase after mypy upgrade [airflow]
jscheffl opened a new pull request, #53243:
URL: https://github.com/apache/airflow/pull/53243
Relates to #53241
I realized that a generated `type: ignore` is produced by pre-commit which is not needed after mypy upgrade - this PR updates all with the update of pre-commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove type ignore across codebase after mypy upgrade [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #53243:
URL: https://github.com/apache/airflow/pull/53243#discussion_r2202871224
##########
providers/amazon/tests/system/__init__.py:
##########
@@ -14,4 +14,3 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore
Review Comment:
Interesting... I did not remove them... some pre-commit did.
So will restore them...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove type ignore across codebase after mypy upgrade [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #53243:
URL: https://github.com/apache/airflow/pull/53243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove type ignore across codebase after mypy upgrade [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #53243:
URL: https://github.com/apache/airflow/pull/53243#discussion_r2202867525
##########
providers/amazon/tests/system/__init__.py:
##########
@@ -14,4 +14,3 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore
Review Comment:
looks like some are got removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove type ignore across codebase after mypy upgrade [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #53243:
URL: https://github.com/apache/airflow/pull/53243#discussion_r2202867525
##########
providers/amazon/tests/system/__init__.py:
##########
@@ -14,4 +14,3 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore
Review Comment:
looks like some are got removed completely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove type ignore across codebase after mypy upgrade [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #53243:
URL: https://github.com/apache/airflow/pull/53243#discussion_r2202869048
##########
providers/amazon/tests/system/__init__.py:
##########
@@ -14,4 +14,3 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-__path__ = __import__("pkgutil").extend_path(__path__, __name__) # type: ignore
Review Comment:
Yeah. Those are needed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove type ignore across codebase after mypy upgrade [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53243:
URL: https://github.com/apache/airflow/pull/53243#issuecomment-3066683769
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org