You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/09/24 23:27:08 UTC
Review Request 38734: Cleaned up function signatures to use Option.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38734/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Also make use of delegating constructors to reduce redundancy in the master
detector and master contender.
Diffs
-----
src/master/contender.hpp 927601c73f3ba56cafb366502a5f58a71c581837
src/master/contender.cpp 67562f19754bd57e293b62d0b7547ff2e6cf18ad
src/master/detector.hpp d31ce532e0b26569e521b21893ef91d771fc20bc
src/master/detector.cpp d0d10e58cc32f5ba9da1bd35a66dcbf66665c204
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
Diff: https://reviews.apache.org/r/38734/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 38734: Cleaned up function signatures to use
Option.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38734/#review100501
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38734]
All tests passed.
- Mesos ReviewBot
On Sept. 24, 2015, 9:27 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38734/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 9:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also make use of delegating constructors to reduce redundancy in the master
> detector and master contender.
>
>
> Diffs
> -----
>
> src/master/contender.hpp 927601c73f3ba56cafb366502a5f58a71c581837
> src/master/contender.cpp 67562f19754bd57e293b62d0b7547ff2e6cf18ad
> src/master/detector.hpp d31ce532e0b26569e521b21893ef91d771fc20bc
> src/master/detector.cpp d0d10e58cc32f5ba9da1bd35a66dcbf66665c204
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
>
> Diff: https://reviews.apache.org/r/38734/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 38734: Cleaned up function signatures to use
Option.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38734/#review102724
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 24, 2015, 9:27 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38734/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 9:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also make use of delegating constructors to reduce redundancy in the master
> detector and master contender.
>
>
> Diffs
> -----
>
> src/master/contender.hpp 927601c73f3ba56cafb366502a5f58a71c581837
> src/master/contender.cpp 67562f19754bd57e293b62d0b7547ff2e6cf18ad
> src/master/detector.hpp d31ce532e0b26569e521b21893ef91d771fc20bc
> src/master/detector.cpp d0d10e58cc32f5ba9da1bd35a66dcbf66665c204
> src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
>
> Diff: https://reviews.apache.org/r/38734/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>