[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend
URL: https://github.com/apache/incubator-pinot/pull/4419#discussion_r302670565
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
 ##########
 @@ -374,8 +379,8 @@ public Response createDetectionPipelineApi(
     }
 
     LOG.info("Detection created with id " + detectionConfigId + " using payload " + payload);
-    responseMessage.put("detectionMsg", "Alert was created successfully.");
-    responseMessage.put("detectionMsg-moreInfo", "Record saved with id " + detectionConfigId);
+    responseMessage.put("message", "Alert was created successfully.");
 
 Review comment:
   Frontend uses the toast popup to display this error message.
   
   Earlier, we used to display the messages just below the editor(by parsing detectionMsg and subscriptionMsg) but that seems to be broken. We can clean that up in the frontend and just rely on the toast popup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org