[GitHub] [hive] zeroflag commented on pull request #1733: HIVE-24346. Store HPL/SQL packages into HMS (amagyar)

[GitBox <gi...@apache.org>]

zeroflag commented on pull request #1733:
URL: https://github.com/apache/hive/pull/1733#issuecomment-768406372


   @mustafaiman, thanks for the review.
   
   get_all_stored_procedures is used drop_package is used in HiveMetaStore>>drop_database_core() when dropping a DB. Without removing the packages first the DB drop would fail with FK key violation.
   
   Regarding the InMemoryPackageRegistry/Package hashmap thing I have to think about it. Right now it doesn't look interchangeable to me. The package registry contains the source code while the hashmap in exec contains the parsed structure. 
   
   I agree with the doing the uppercase conversion should take place at the boundary once.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org