You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/11 13:43:16 UTC
[GitHub] [accumulo-testing] Manno15 opened a new pull request #136: Fixes #135. Fix build errors due recent changes in accumulo
Manno15 opened a new pull request #136:
URL: https://github.com/apache/accumulo-testing/pull/136
closes #135.
Changes property names to the respective Manager ones. Also, SimpleThreadPool was removed so that has been changed to ThreadPools.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime edited a comment on pull request #136: Fixes #135. Fix build errors due recent changes in accumulo
Posted by GitBox <gi...@apache.org>.
milleruntime edited a comment on pull request #136:
URL: https://github.com/apache/accumulo-testing/pull/136#issuecomment-777473254
> Once you are happy with these fixes, you could push them to a `2.1` branch for development testing until we release 2.1.
Another option is to tag a release for 2.0 and then make `main` work with 2.1.0-SNAPSHOT. @ctubbsii what do you think would be easiest?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on pull request #136: Fixes #135. Fix build errors due recent changes in accumulo
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #136:
URL: https://github.com/apache/accumulo-testing/pull/136#issuecomment-777701521
I've taken the liberty of pushing a 2.0 branch to this repo, based on the current main branch at ec55973f5bdd297666090087e4792aa32d2c3d5e (the branch itself can be renamed later, if we don't like the naming convention). So, if you want to merge this into the main branch for 2.1, that should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] Manno15 merged pull request #136: Fixes #135. Fix build errors due recent changes in accumulo
Posted by GitBox <gi...@apache.org>.
Manno15 merged pull request #136:
URL: https://github.com/apache/accumulo-testing/pull/136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime commented on pull request #136: Fixes #135. Fix build errors due recent changes in accumulo
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #136:
URL: https://github.com/apache/accumulo-testing/pull/136#issuecomment-777471655
Once you are happy with these fixes, you could push them to a `2.1` branch for development testing until we release 2.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on pull request #136: Fixes #135. Fix build errors due recent changes in accumulo
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #136:
URL: https://github.com/apache/accumulo-testing/pull/136#issuecomment-777699082
> > Once you are happy with these fixes, you could push them to a `2.1` branch for development testing until we release 2.1.
>
> Another option is to tag a release for 2.0 and then make `main` work with 2.1.0-SNAPSHOT. @ctubbsii what do you think would be easiest?
Making main work with 2.1.0-SNAPSHOT would be convenient for developers. We don't perform releases from this repo, so we should avoid referring to it by that term, which has a specific meaning within the ASF.
I prefer a 2.0 branch rather than a tag, though, because we don't need to freeze the testing code for 2.0 just because we're not doing releases of Accumulo 2.0 anymore. For example, we may wish to write a new test for 2.1, and maintain an equivalent version of it for 2.0 to compare the differences between the two Accumulo release lines. You can do that with a 2.0 branch, but not with a tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime commented on pull request #136: Fixes #135. Fix build errors due recent changes in accumulo
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #136:
URL: https://github.com/apache/accumulo-testing/pull/136#issuecomment-777473254
> Once you are happy with these fixes, you could push them to a `2.1` branch for development testing until we release 2.1.
Another option is to tag a release for 2.0 and then make `main` work with 2.1.0-SNAPSHOT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org