You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by GitBox <gi...@apache.org> on 2022/04/28 08:54:21 UTC
[GitHub] [johnzon] dblevins opened a new pull request, #89: Ensure Snippet works as intended for other JsonGenerator implementations
dblevins opened a new pull request, #89:
URL: https://github.com/apache/johnzon/pull/89
If our intent is to optimize for small snippets and support JSONP implementations aside from Johnzon, we still need to fall back to doing the `flush()`.
The only reason we were able to get rid of the `flush()` calls is because we added `Buffered` inside Johnzon. Other JSON-P implementations won't understand that interface and are likely to have their own buffering. In those situations we'll need to flush to ensure the SnippetWriter `terminate()` calls work. It's only for Johnzon that we can skip them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jeanouii closed pull request #89: Ensure Snippet works as intended for other JsonGenerator implementations
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii closed pull request #89: Ensure Snippet works as intended for other JsonGenerator implementations
URL: https://github.com/apache/johnzon/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #89: Ensure Snippet works as intended for other JsonGenerator implementations
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-1378657470
@jeanouii AFAIK we did the work in the merged PR so think we can close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #89: Ensure Snippet works as intended for other JsonGenerator implementations
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-1358148847
guess this one is ok now? should we close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #89: Ensure Snippet works as intended for other JsonGenerator implementations
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-1111949924
@dblevins idea was to use the full string representation without johnzon (check the SnippetFactory used). It is ok to be in degraded mode for this case with other implementations. Ultimately if you want to enhance more this case you also need to change the SnippetFactory for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jeanouii commented on pull request #89: Ensure Snippet works as intended for other JsonGenerator implementations
Posted by GitBox <gi...@apache.org>.
jeanouii commented on PR #89:
URL: https://github.com/apache/johnzon/pull/89#issuecomment-1378636777
Does ok mean already merged in another PR so we can close without merge?
Or does it mean, it's ready to be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org