You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/09/23 15:37:00 UTC
[jira] [Work logged] (COLLECTIONS-796)
SetUniqueList.createSetBasedOnList doesn't add list elements to return
value
[ https://issues.apache.org/jira/browse/COLLECTIONS-796?focusedWorklogId=654579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654579 ]
ASF GitHub Bot logged work on COLLECTIONS-796:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/21 15:36
Start Date: 23/Sep/21 15:36
Worklog Time Spent: 10m
Work Description: cbkurz opened a new pull request #255:
URL: https://github.com/apache/commons-collections/pull/255
* There seems no immediate reason why the addAll was removed in commit b1c45ac691d46a8c609f2534d2adfa59c0599527
* Tests added
* Functionality implemented again
* removed typo in UnmodifiableListIterator.unmodifiableListIterator (previous 'UnmodifiableListIterator.umodifiableListIterator')
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 654579)
Remaining Estimate: 50m (was: 1h)
Time Spent: 10m
> SetUniqueList.createSetBasedOnList doesn't add list elements to return value
> ----------------------------------------------------------------------------
>
> Key: COLLECTIONS-796
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-796
> Project: Commons Collections
> Issue Type: Bug
> Components: List
> Affects Versions: 4.3, 4.4
> Reporter: Owen Mansel-Chan
> Priority: Minor
> Labels: easyfix, newbie
> Original Estimate: 1h
> Time Spent: 10m
> Remaining Estimate: 50m
>
> SetUniqueList.createSetBasedOnList doesn't add list elements to the return value any more. The documentation says it does, and it used to up to version 4.2, but a call to `addAll` was accidentally deleted. I found where the mistake was introduced on github:
> https://github.com/apache/commons-collections/commit/b1c45ac691d46a8c609f2534d2adfa59c0599527#diff-8e53271d5d8299a76d43b0e3c81740fbe660083ae71c5bf2be63846d52156f23L344
--
This message was sent by Atlassian Jira
(v8.3.4#803005)