You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/23 16:59:27 UTC

[GitHub] vandanavk commented on a change in pull request #12291: [MXNET-817] Fixes to speech recognition example

vandanavk commented on a change in pull request #12291: [MXNET-817] Fixes to speech recognition example
URL: https://github.com/apache/incubator-mxnet/pull/12291#discussion_r212383980
 
 

 ##########
 File path: example/speech_recognition/singleton.py
 ##########
 @@ -32,7 +32,7 @@ def getInstance(self):
 
     def __new__(class_, *args, **kwargs):
         print("__new__")
-        class_.instances[class_] = super(Singleton, class_).__new__(class_, *args, **kwargs)
+        class_.instances[class_] = super().__new__(class_, *args, **kwargs)
 
 Review comment:
   Python3 complained about this usage of super(Singleton, class_).
   LogUtil's singleton looks much cleaner. Will refactor the code around this. Wanted to make minimal changes to get the example working/not break it - but I think this is essential. Will make the changes and resubmit. Thanks @anirudhacharya 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services