You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2014/03/02 02:06:33 UTC
svn commit: r1573245 - in /httpcomponents/httpclient/branches/4.3.x:
httpclient-cache/src/test/java/org/apache/http/impl/client/cache/
httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ehcache/
httpclient-osgi/src/test/java/org/apache/ht...
Author: sebb
Date: Sun Mar 2 01:06:32 2014
New Revision: 1573245
URL: http://svn.apache.org/r1573245
Log:
Eliminate/suppress warnings in test code
Modified:
httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidationRequest.java
httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidator.java
httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCacheKeyGenerator.java
httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingExecChain.java
httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java
httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ehcache/TestEhcacheHttpCacheStorage.java
httpcomponents/httpclient/branches/4.3.x/httpclient-osgi/src/test/java/org/apache/http/osgi/impl/TestPropertiesUtils.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/client/utils/TestHttpClientUtils.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/TestEofSensorInputStream.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLContextBuilder.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/auth/TestHttpAuthenticator.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestAuthenticationStrategy.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestBasicResponseHandler.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestBasicHttpClientConnectionManager.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestDefaultRoutePlanner.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestHttpClientConnectionOperator.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestPoolingHttpClientConnectionManager.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestSystemDefaultRoutePlanner.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMainClientExec.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMinimalClientExec.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestProtocolExec.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRedirectExec.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestResponseEntityWrapper.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRetryExec.java
httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestServiceUnavailableRetryExec.java
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidationRequest.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidationRequest.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidationRequest.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidationRequest.java Sun Mar 2 01:06:32 2014
@@ -45,6 +45,7 @@ import org.easymock.classextension.EasyM
import org.junit.Before;
import org.junit.Test;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestAsynchronousValidationRequest {
private AsynchronousValidator mockParent;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidator.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidator.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestAsynchronousValidator.java Sun Mar 2 01:06:32 2014
@@ -47,6 +47,7 @@ import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestAsynchronousValidator {
private AsynchronousValidator impl;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCacheKeyGenerator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCacheKeyGenerator.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCacheKeyGenerator.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCacheKeyGenerator.java Sun Mar 2 01:06:32 2014
@@ -39,6 +39,7 @@ import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestCacheKeyGenerator {
private static final BasicHttpRequest REQUEST_FULL_EPISODES = new BasicHttpRequest("GET",
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingExecChain.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingExecChain.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingExecChain.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestCachingExecChain.java Sun Mar 2 01:06:32 2014
@@ -85,6 +85,7 @@ import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+@SuppressWarnings({"boxing","static-access"}) // test code
public abstract class TestCachingExecChain {
private ClientExecChain impl;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java Sun Mar 2 01:06:32 2014
@@ -70,6 +70,7 @@ import org.junit.Test;
* and are expected to be a drop-in replacement. The test cases captured here
* document the places where we differ from the HTTP RFC.
*/
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestProtocolDeviations {
private static ProtocolVersion HTTP_1_1 = new ProtocolVersion("HTTP", 1, 1);
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java Sun Mar 2 01:06:32 2014
@@ -73,6 +73,7 @@ import org.junit.Test;
* pass downstream to the backend HttpClient are are conditionally compliant
* with the rules for an HTTP/1.1 client.
*/
+@SuppressWarnings({"static-access"}) // test code
public class TestProtocolRequirements extends AbstractProtocolTest {
@Test
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ehcache/TestEhcacheHttpCacheStorage.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ehcache/TestEhcacheHttpCacheStorage.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ehcache/TestEhcacheHttpCacheStorage.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ehcache/TestEhcacheHttpCacheStorage.java Sun Mar 2 01:06:32 2014
@@ -43,6 +43,7 @@ import org.apache.http.impl.client.cache
import org.easymock.EasyMock;
import org.junit.Test;
+@SuppressWarnings({"boxing"}) // test code
public class TestEhcacheHttpCacheStorage extends TestCase {
private Ehcache mockCache;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient-osgi/src/test/java/org/apache/http/osgi/impl/TestPropertiesUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient-osgi/src/test/java/org/apache/http/osgi/impl/TestPropertiesUtils.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient-osgi/src/test/java/org/apache/http/osgi/impl/TestPropertiesUtils.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient-osgi/src/test/java/org/apache/http/osgi/impl/TestPropertiesUtils.java Sun Mar 2 01:06:32 2014
@@ -40,14 +40,15 @@ public final class TestPropertiesUtils {
@Test
public void toBoolean() {
assertConverted(true, null, boolean.class, true);
- assertConverted(true, null, Boolean.class, true);
+ assertConverted(true, null, Boolean.class, true); // TODO should these be Boolean.TRUE?
assertConverted(false, "false", boolean.class, null);
- assertConverted(false, "false", Boolean.class, null);
+ assertConverted(false, "false", Boolean.class, null); // TODO should these be Boolean.FALSE?
// whatever value is interpreted as `false` by Boolean.valueOf
assertConverted(false, "not a boolean", boolean.class, true);
- assertConverted(false, "not a boolean", Boolean.class, true);
+ assertConverted(false, "not a boolean", Boolean.class, true); // TODO should these be Boolean.FALSE/TRUE?
}
+ @SuppressWarnings("boxing")
@Test
public void toSingleString() {
assertConverted("fallback to default value", null, String.class, "fallback to default value");
@@ -59,6 +60,7 @@ public final class TestPropertiesUtils {
assertConverted("456789", 456789, String.class, null);
}
+ @SuppressWarnings("boxing")
@Test
public void toStringArray() {
assertConvertedArray(new String[]{"fallback to default value"},
@@ -86,6 +88,7 @@ public final class TestPropertiesUtils {
new String[]{"fallback to default value"});
}
+ @SuppressWarnings("boxing")
@Test
public void toInt() {
assertConverted(123, null, int.class, 123);
@@ -96,6 +99,7 @@ public final class TestPropertiesUtils {
assertConverted(789, "not an integer", Integer.class, 789);
}
+ @SuppressWarnings("boxing")
@Test
public void toLong() {
assertConverted(123l, null, long.class, 123l);
@@ -106,6 +110,7 @@ public final class TestPropertiesUtils {
assertConverted(789l, "not a long", Long.class, 789l);
}
+ @SuppressWarnings("boxing")
@Test
public void toDouble() {
assertConverted(123d, null, double.class, 123d);
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/client/utils/TestHttpClientUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/client/utils/TestHttpClientUtils.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/client/utils/TestHttpClientUtils.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/client/utils/TestHttpClientUtils.java Sun Mar 2 01:06:32 2014
@@ -36,6 +36,7 @@ import org.apache.http.impl.client.Close
import org.junit.Test;
import org.mockito.Mockito;
+@SuppressWarnings({"boxing"}) // test code
public class TestHttpClientUtils {
@Test
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/TestEofSensorInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/TestEofSensorInputStream.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/TestEofSensorInputStream.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/TestEofSensorInputStream.java Sun Mar 2 01:06:32 2014
@@ -34,6 +34,7 @@ import org.junit.Before;
import org.junit.Test;
import org.mockito.Mockito;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestEofSensorInputStream {
private InputStream instream;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java Sun Mar 2 01:06:32 2014
@@ -40,6 +40,7 @@ import org.junit.Test;
/**
* Tests for {@link RouteTracker}.
*/
+@SuppressWarnings({"boxing"}) // test code
public class TestRouteTracker {
// a selection of constants for generating routes
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLContextBuilder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLContextBuilder.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLContextBuilder.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLContextBuilder.java Sun Mar 2 01:06:32 2014
@@ -82,7 +82,7 @@ public class TestSSLContextBuilder {
final KeyStore keystore = load("test-keypasswd.keystore", "nopassword".toCharArray());
final String keyPassword = "password";
new SSLContextBuilder()
- .loadKeyMaterial(keystore, keyPassword != null ? keyPassword.toCharArray() : null)
+ .loadKeyMaterial(keystore, keyPassword.toCharArray())
.loadTrustMaterial(keystore)
.build();
}
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/auth/TestHttpAuthenticator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/auth/TestHttpAuthenticator.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/auth/TestHttpAuthenticator.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/auth/TestHttpAuthenticator.java Sun Mar 2 01:06:32 2014
@@ -64,6 +64,7 @@ import org.junit.Before;
import org.junit.Test;
import org.mockito.Mockito;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestHttpAuthenticator {
private AuthenticationStrategy authStrategy;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestAuthenticationStrategy.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestAuthenticationStrategy.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestAuthenticationStrategy.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestAuthenticationStrategy.java Sun Mar 2 01:06:32 2014
@@ -62,6 +62,7 @@ import org.mockito.Mockito;
/**
* Simple tests for {@link AuthenticationStrategyImpl}.
*/
+@SuppressWarnings({"boxing"}) // test code
public class TestAuthenticationStrategy {
@Test(expected=IllegalArgumentException.class)
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestBasicResponseHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestBasicResponseHandler.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestBasicResponseHandler.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/client/TestBasicResponseHandler.java Sun Mar 2 01:06:32 2014
@@ -58,6 +58,7 @@ public class TestBasicResponseHandler {
Assert.assertEquals("stuff", s);
}
+ @SuppressWarnings("boxing")
@Test
public void testUnsuccessfulResponse() throws Exception {
final InputStream instream = Mockito.mock(InputStream.class);
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestBasicHttpClientConnectionManager.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestBasicHttpClientConnectionManager.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestBasicHttpClientConnectionManager.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestBasicHttpClientConnectionManager.java Sun Mar 2 01:06:32 2014
@@ -54,6 +54,7 @@ import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestBasicHttpClientConnectionManager {
@Mock
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestDefaultRoutePlanner.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestDefaultRoutePlanner.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestDefaultRoutePlanner.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestDefaultRoutePlanner.java Sun Mar 2 01:06:32 2014
@@ -45,6 +45,7 @@ import org.mockito.Mockito;
/**
* Tests for {@link DefaultRoutePlanner}.
*/
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestDefaultRoutePlanner {
private SchemePortResolver schemePortResolver;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestHttpClientConnectionOperator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestHttpClientConnectionOperator.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestHttpClientConnectionOperator.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestHttpClientConnectionOperator.java Sun Mar 2 01:06:32 2014
@@ -50,6 +50,7 @@ import org.junit.Before;
import org.junit.Test;
import org.mockito.Mockito;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestHttpClientConnectionOperator {
private ManagedHttpClientConnection conn;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestPoolingHttpClientConnectionManager.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestPoolingHttpClientConnectionManager.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestPoolingHttpClientConnectionManager.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestPoolingHttpClientConnectionManager.java Sun Mar 2 01:06:32 2014
@@ -60,6 +60,7 @@ import org.mockito.MockitoAnnotations;
/**
* {@link PoolingHttpClientConnectionManager} tests.
*/
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestPoolingHttpClientConnectionManager {
@Mock
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestSystemDefaultRoutePlanner.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestSystemDefaultRoutePlanner.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestSystemDefaultRoutePlanner.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/conn/TestSystemDefaultRoutePlanner.java Sun Mar 2 01:06:32 2014
@@ -51,6 +51,7 @@ import org.mockito.Mockito;
/**
* Tests for {@link SystemDefaultRoutePlanner}.
*/
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestSystemDefaultRoutePlanner {
private SchemePortResolver schemePortResolver;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMainClientExec.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMainClientExec.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMainClientExec.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMainClientExec.java Sun Mar 2 01:06:32 2014
@@ -90,6 +90,7 @@ import org.mockito.MockitoAnnotations;
import org.mockito.invocation.InvocationOnMock;
import org.mockito.stubbing.Answer;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestMainClientExec {
@Mock
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMinimalClientExec.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMinimalClientExec.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMinimalClientExec.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestMinimalClientExec.java Sun Mar 2 01:06:32 2014
@@ -66,6 +66,7 @@ import java.lang.reflect.Proxy;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestMinimalClientExec {
@Mock
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestProtocolExec.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestProtocolExec.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestProtocolExec.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestProtocolExec.java Sun Mar 2 01:06:32 2014
@@ -50,6 +50,7 @@ import org.mockito.MockitoAnnotations;
import java.io.IOException;
import java.net.URI;
+@SuppressWarnings({"static-access"}) // test code
public class TestProtocolExec {
@Mock
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRedirectExec.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRedirectExec.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRedirectExec.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRedirectExec.java Sun Mar 2 01:06:32 2014
@@ -64,6 +64,7 @@ import java.io.ByteArrayInputStream;
import java.io.InputStream;
import java.util.List;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestRedirectExec {
@Mock
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestResponseEntityWrapper.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestResponseEntityWrapper.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestResponseEntityWrapper.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestResponseEntityWrapper.java Sun Mar 2 01:06:32 2014
@@ -38,6 +38,7 @@ import org.junit.Before;
import org.junit.Test;
import org.mockito.Mockito;
+@SuppressWarnings({"boxing"}) // test code
public class TestResponseEntityWrapper {
private InputStream instream;
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRetryExec.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRetryExec.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRetryExec.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestRetryExec.java Sun Mar 2 01:06:32 2014
@@ -52,6 +52,7 @@ import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestRetryExec {
@Mock
Modified: httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestServiceUnavailableRetryExec.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestServiceUnavailableRetryExec.java?rev=1573245&r1=1573244&r2=1573245&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestServiceUnavailableRetryExec.java (original)
+++ httpcomponents/httpclient/branches/4.3.x/httpclient/src/test/java/org/apache/http/impl/execchain/TestServiceUnavailableRetryExec.java Sun Mar 2 01:06:32 2014
@@ -42,6 +42,7 @@ import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
+@SuppressWarnings({"boxing","static-access"}) // test code
public class TestServiceUnavailableRetryExec {
@Mock