You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2012/11/21 23:32:57 UTC
[jira] [Created] (HBASE-7204) Make hbck ErrorReporter pluggable
Jimmy Xiang created HBASE-7204:
----------------------------------
Summary: Make hbck ErrorReporter pluggable
Key: HBASE-7204
URL: https://issues.apache.org/jira/browse/HBASE-7204
Project: HBase
Issue Type: Improvement
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Minor
Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
0.94.3
Status: Resolved (was: Patch Available)
Ran tests locally. Integrated into trunk and 0.94.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7204:
---------------------------------
Fix Version/s: (was: 0.94.3)
0.94.4
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.96.0, 0.94.4
>
> Attachments: 0.94-7204.patch, trunk-7204.addendum, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Status: Open (was: Patch Available)
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506639#comment-13506639 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
Right -- what I'm saying is that I don't think we can specify the system property (as opposed to xml config property) if we use the normal hbase script. e.g. -- I don't think this will work as expected.
hbase hbck -Dsystem.property=foo blah blah
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506700#comment-13506700 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
I'm -0 on the current approach (not going to block but don't like), +1 if tool is used.
Using Tool is really simple -- just rename main to run and replace main with the equivalent of this.
{code}
public static void main(String[] args) throws Exception {
int ret = ToolRunner.run(new LoadIncrementalHFiles(HBaseConfiguration.create()), args);
System.exit(ret);
}
{code}
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506177#comment-13506177 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
First I'd double check what I said to make sure it is true. (I'm going off of documentation, haven't actually tried it).
I wasn't aware of Tool when we overhauled hbck a while back. From a usability point of view, I'd really prefer it if we "Tool"'ed hbck. (look at copy table, or import/export for examples -- it is really simple).
The system properties approach won't work intuitively with the hbase script, and the extra wrapper code will save trouble down the line.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506877#comment-13506877 ]
Jimmy Xiang commented on HBASE-7204:
------------------------------------
Thanks for the review. I need to do a minor change to fix a test failure. I will do that before I commit.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
Try hadoopqa again.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507832#comment-13507832 ]
Hudson commented on HBASE-7204:
-------------------------------
Integrated in HBase-TRUNK #3585 (See [https://builds.apache.org/job/HBase-TRUNK/3585/])
HBASE-7204 Make hbck ErrorReporter pluggable, ADDENDUM (Revision 1415897)
Result = FAILURE
jxiang :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.addendum, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506873#comment-13506873 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
+1 lgtm.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503245#comment-13503245 ]
ramkrishna.s.vasudevan commented on HBASE-7204:
-----------------------------------------------
Patch looks good. Same as what Jon said..Thanks
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506109#comment-13506109 ]
Jimmy Xiang commented on HBASE-7204:
------------------------------------
I see. However, hbck doesn't use the Tool class for now.
This way (with System property), we don't have to put the configuration in a file. If it is in a configuration file, it can be overridden from command line.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Component/s: hbck
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Release Note: Now hbck runs with ToolRunner, and can accept configurations from command line.
Status: Patch Available (was: Open)
Addressed Jon and Ram's comments. Now hbck runs with ToolRunner, and can accept configurations from command line.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507790#comment-13507790 ]
Hudson commented on HBASE-7204:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #282 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/282/])
HBASE-7204 Make hbck ErrorReporter pluggable (Revision 1415871)
Result = FAILURE
jxiang :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Status: Patch Available (was: Open)
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Attachment: trunk-7204.patch
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507762#comment-13507762 ]
Hudson commented on HBASE-7204:
-------------------------------
Integrated in HBase-TRUNK #3584 (See [https://builds.apache.org/job/HBase-TRUNK/3584/])
HBASE-7204 Make hbck ErrorReporter pluggable (Revision 1415871)
Result = FAILURE
jxiang :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Attachment: trunk-7204_v2.1.patch
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505833#comment-13505833 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
It depends on where you set it. Let's say you write out the entire command line (including java) like this:
{code}
java -Dsystem.property=foo org.apache.hadoop.hbase.util.HBaseFsck -Dconf.property=bar
{code}
The -Dsystem.property options come from the jvm invocation (its a jvm thing). The -Dconf.property options come form the Tool class that handles cmd line parsing of argv[]. They are gathered and put into the Configuration. (its a hadoop convention).
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506695#comment-13506695 ]
Jimmy Xiang commented on HBASE-7204:
------------------------------------
Cool. Can we handle that in a separate jira so that we can have this capability now (overriding this conf from command line for hbck)?
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506885#comment-13506885 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
Thanks for making the changes! feel free to commit if the test fix is trivial
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506689#comment-13506689 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
Ok, well that needs to be documented (release notes?). Honestly, I'd still prefer if this was turned into a Tool since the rest of the hbase tools like import/export/copytable/LoadIncrementalHFiles do this. I think this is a hadoop platform convention, not just an MR convention.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503524#comment-13503524 ]
Jimmy Xiang commented on HBASE-7204:
------------------------------------
-Dhbasefsck.errorreporter=x will set it in the system properties, right?
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Attachment: 0.94-7204.patch
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Status: Open (was: Patch Available)
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507833#comment-13507833 ]
Hudson commented on HBASE-7204:
-------------------------------
Integrated in HBase-0.94 #609 (See [https://builds.apache.org/job/HBase-0.94/609/])
HBASE-7204 Make hbck ErrorReporter pluggable, ADDENDUM (Revision 1415898)
Result = SUCCESS
jxiang :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.addendum, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507786#comment-13507786 ]
Hudson commented on HBASE-7204:
-------------------------------
Integrated in HBase-0.94 #608 (See [https://builds.apache.org/job/HBase-0.94/608/])
HBASE-7204 Make hbck ErrorReporter pluggable (Revision 1415876)
Result = SUCCESS
jxiang :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506711#comment-13506711 ]
Jimmy Xiang commented on HBASE-7204:
------------------------------------
Okay. Let me convert it to Tool and post a new patch.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502545#comment-13502545 ]
Hadoop QA commented on HBASE-7204:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12554606/trunk-7204.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 98 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestHCM
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3396//console
This message is automatically generated.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Attachment: trunk-7204_v2.patch
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507940#comment-13507940 ]
Hudson commented on HBASE-7204:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #283 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/283/])
HBASE-7204 Make hbck ErrorReporter pluggable, ADDENDUM (Revision 1415897)
Result = FAILURE
jxiang :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.addendum, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503192#comment-13503192 ]
Jonathan Hsieh commented on HBASE-7204:
---------------------------------------
{code}
+ String className = System.getProperty("hbasefsck.errorreporter");
{code}
Why is this System property? Why not a configuration property? (command line overrideable via -Dhbasefsck.errorreporter)?
otherwise, lgtm.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-7204:
-------------------------------
Attachment: trunk-7204.addendum
Attached an addendum to fix the jdk 1.7 test issue.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 0.94-7204.patch, trunk-7204.addendum, trunk-7204.patch, trunk-7204_v2.1.patch, trunk-7204_v2.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506655#comment-13506655 ]
Jimmy Xiang commented on HBASE-7204:
------------------------------------
I tried it yesterday. We can run it like this:
HBASE_OPTS=-Dkey=value hbase hbck ...
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7204) Make hbck ErrorReporter pluggable
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506603#comment-13506603 ]
Jimmy Xiang commented on HBASE-7204:
------------------------------------
Tool is more for MR. The patch still uses the regular configuration if it's not specified in system properties.
> Make hbck ErrorReporter pluggable
> ---------------------------------
>
> Key: HBASE-7204
> URL: https://issues.apache.org/jira/browse/HBASE-7204
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: trunk-7204.patch
>
>
> Make hbck ErrorReporter pluggable so that it can be replaced dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira