You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/01 13:32:58 UTC
Re: Review Request 70942: Added a test for 'reviveOffers(roles)'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70942/
-----------------------------------------------------------
(Updated July 1, 2019, 1:32 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added a test for 'reviveOffers(roles)'.
Diffs (updated)
-----
src/tests/scheduler_driver_tests.cpp 46af8d2c0fff15974b028521d1434e67bd9217da
Diff: https://reviews.apache.org/r/70942/diff/3/
Changes: https://reviews.apache.org/r/70942/diff/2-3/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="MesosSchedulerDriverTest*ReviveSingleRole*" --gtest_break_on_failure --gtest_repeat=1000`
Thanks,
Andrei Sekretenko
Re: Review Request 70942: Added a test for 'reviveOffers(roles)'.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70942/#review216369
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 3, 2019, 3:55 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70942/
> -----------------------------------------------------------
>
> (Updated July 3, 2019, 3:55 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for 'reviveOffers(roles)'.
>
>
> Diffs
> -----
>
> src/tests/scheduler_driver_tests.cpp 80f3335b0054ed0e458c175700765293dfd6a929
>
>
> Diff: https://reviews.apache.org/r/70942/diff/4/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="MesosSchedulerDriverTest*ReviveSingleRole*" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70942: Added a test for 'reviveOffers(roles)'.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70942/
-----------------------------------------------------------
(Updated July 3, 2019, 3:55 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Reverted `settle()` removal, fixed a comment to explain why it is really needed.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description
-------
Added a test for 'reviveOffers(roles)'.
Diffs (updated)
-----
src/tests/scheduler_driver_tests.cpp 80f3335b0054ed0e458c175700765293dfd6a929
Diff: https://reviews.apache.org/r/70942/diff/4/
Changes: https://reviews.apache.org/r/70942/diff/3-4/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="MesosSchedulerDriverTest*ReviveSingleRole*" --gtest_break_on_failure --gtest_repeat=1000`
Thanks,
Andrei Sekretenko