You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by aa...@apache.org on 2023/03/29 02:36:02 UTC
[rocketmq-clients] branch master updated: Don't use GaugeObserver#close (#429)
This is an automated email from the ASF dual-hosted git repository.
aaronai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push:
new 138138ef Don't use GaugeObserver#close (#429)
138138ef is described below
commit 138138ef2d4908cc7af608b9d219bab961f89ff1
Author: Aaron Ai <ya...@gmail.com>
AuthorDate: Wed Mar 29 10:35:56 2023 +0800
Don't use GaugeObserver#close (#429)
---
.../rocketmq/client/java/metrics/ClientMeterManager.java | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/metrics/ClientMeterManager.java b/java/client/src/main/java/org/apache/rocketmq/client/java/metrics/ClientMeterManager.java
index 22ec939a..c07e06e9 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/metrics/ClientMeterManager.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/metrics/ClientMeterManager.java
@@ -27,7 +27,6 @@ import io.grpc.netty.shaded.io.netty.handler.ssl.SslContextBuilder;
import io.grpc.netty.shaded.io.netty.handler.ssl.util.InsecureTrustManagerFactory;
import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.metrics.Meter;
-import io.opentelemetry.api.metrics.ObservableDoubleGauge;
import io.opentelemetry.exporter.otlp.metrics.OtlpGrpcMetricExporter;
import io.opentelemetry.sdk.OpenTelemetrySdk;
import io.opentelemetry.sdk.metrics.InstrumentSelector;
@@ -78,7 +77,7 @@ public class ClientMeterManager {
clientMeter.shutdown();
}
- @SuppressWarnings("deprecation")
+ @SuppressWarnings({"deprecation", "resource"})
public synchronized void reset(Metric metric) {
try {
if (clientMeter.satisfy(metric)) {
@@ -156,8 +155,7 @@ public class ClientMeterManager {
final List<GaugeEnum> gauges = gaugeObserver.getGauges();
for (GaugeEnum gauge : gauges) {
- final String name = gauge.getName();
- try (ObservableDoubleGauge ignored = meter.gaugeBuilder(name).buildWithCallback(measurement -> {
+ meter.gaugeBuilder(gauge.getName()).buildWithCallback(measurement -> {
final Map<Attributes, Double> map = gaugeObserver.getValues(gauge);
if (map.isEmpty()) {
return;
@@ -167,11 +165,7 @@ public class ClientMeterManager {
final Double value = entry.getValue();
measurement.record(value, attributes);
}
- })) {
- log.debug("Build observable double gauge successfully, gauge={}, clientId={}", name, clientId);
- } catch (Exception e) {
- log.error("Failed to build observable double gauge, gauge={}, clientId={}", name, clientId, e);
- }
+ });
}
} catch (Throwable t) {
log.error("Exception raised when resetting message meter, clientId={}", clientId, t);