[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #584: GUACAMOLE-1199: Only update unrestricted JDBC attributes if they have been provided.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #584:
URL: https://github.com/apache/guacamole-client/pull/584#discussion_r682368446



##########
File path: extensions/guacamole-auth-totp/src/main/java/org/apache/guacamole/auth/totp/user/UserVerificationService.java
##########
@@ -166,7 +166,7 @@ private boolean setKey(UserContext context, UserTOTPKey key)
 
         // Get mutable set of attributes
         User self = context.self();
-        Map<String, String> attributes = new HashMap<String, String>();
+        Map<String, String> attributes = new HashMap<>(self.getAttributes());

Review comment:
       This might have something to do with the logic that decides whether an attribute field appears in the edit screens. Essentially all attributes with corresponding form information are shown when creating things, but only fields with corresponding explicit values (even if blank) are shown when editing.
   
   I thought there was logic in place that returned `""` values for these attributes if unset...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org