Re: [PR] feat!(storage): Integration Storage trait with FileIO [iceberg-rust]

["blackmwk (via GitHub)" <gi...@apache.org>]

blackmwk commented on code in PR #2116:
URL: https://github.com/apache/iceberg-rust/pull/2116#discussion_r2875715063


##########
crates/catalog/glue/src/catalog.rs:
##########
@@ -182,9 +198,11 @@ impl GlueCatalog {
 
         let client = aws_sdk_glue::Client::new(&sdk_config);
 
-        let file_io = FileIO::from_path(&config.warehouse)?
+        // Use provided factory or default to LocalFsStorageFactory
+        let factory = storage_factory.unwrap_or_else(|| Arc::new(LocalFsStorageFactory));

Review Comment:
   Why it's not ideal? I think it's would be odd if the core iceberg crate depends on `iceberg-storage-opendal`, but it would be fine for other crates. Also we could use feature flag to allow user to stop depending on opendal if they don't want. 



##########
bindings/python/src/datafusion_table_provider.rs:
##########
@@ -30,6 +30,29 @@ use pyo3::types::PyCapsule;
 
 use crate::runtime::runtime;
 
+/// Parse the scheme from a URL and return the appropriate StorageFactory.
+fn storage_factory_from_path(path: &str) -> PyResult<Arc<dyn StorageFactory>> {

Review Comment:
   Please create an issue to track this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org