[GitHub] [geode] nvpivot opened pull request #4266: GEODE-7395: Add Micrometer docs

["nvpivot (GitHub)" <gi...@apache.org>]

Created a new section in 'tools' menu where we document what micrometer is, meters we have added, and how to use it.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- ~[ ] Have you written or updated unit tests to verify your changes?~

- ~[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aaronlindsey commented on pull request #4266: GEODE-7395: Add Micrometer docs

["aaronlindsey (GitHub)" <gi...@apache.org>]

Technically this is only true for the `geode.cache.gets` timer. The `geode.function.executions` timer will currently ignore this setting and will always record time.

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nvpivot commented on issue #4266: GEODE-7395: Add Micrometer docs

["nvpivot (GitHub)" <gi...@apache.org>]

@joeymcallister @davebarnes97 @karensmolermiller would one of you or some of you be able to review this, I don't have permissions to add you as reviewers, but I would like your review.

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aaronlindsey commented on pull request #4266: GEODE-7395: Add Micrometer docs

["aaronlindsey (GitHub)" <gi...@apache.org>]

The formatting on these 3 sections looks incorrect in the generated docs.

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aaronlindsey commented on pull request #4266: GEODE-7395: Add Micrometer docs

["aaronlindsey (GitHub)" <gi...@apache.org>]

The formatting of these lists looks incorrect in the generated docs.

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aaronlindsey commented on pull request #4266: GEODE-7395: Add Micrometer docs

["aaronlindsey (GitHub)" <gi...@apache.org>]

The description is missing.

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #4266: GEODE-7395: Add Micrometer docs

["kirklund (GitHub)" <gi...@apache.org>]

We should probably submit another code PR that makes all meters consistent in this regard.

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #4266: GEODE-7395: Add Micrometer docs

["kirklund (GitHub)" <gi...@apache.org>]

Build failed with:
```
ERROR: (gcloud.compute.instances.create) Could not fetch resource:
 - Internal error. Please try again or contact Google Support. (Code: '-1396745325018209338')
```
Retriggering precheckin should hopefully clear this up.

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aaronlindsey commented on pull request #4266: GEODE-7395: Add Micrometer docs

["aaronlindsey (GitHub)" <gi...@apache.org>]

Do you think it would be appropriate to link to the Micrometer example in the geode-example repo here? That example does the same thing as what this page is describing, so if they have questions after reading this page that might be a good reference. 

[ Full content available at: https://github.com/apache/geode/pull/4266 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org