You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2022/09/06 05:16:59 UTC
Review Request 74102: ATLAS-4666 : Intermittently, the audits for creation of hive_db registered are different than expected
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74102/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Pinal Shah, Radhika Kundam, and Sidharth Mishra.
Bugs: ATLAS-4666
https://issues.apache.org/jira/browse/ATLAS-4666
Repository: atlas
Description
-------
Sometimes, when I create a hive database and then check for the same in Atlas, the audits tab shows unexpected audit entries: it shows two audit entries both marked as 'Entity Updated' rather than showing a 'Entity Created' audit entry anywhere.
This patch will check for the Shell entities created and then assign the Entity status to the Audit entry.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java d48c91709
Diff: https://reviews.apache.org/r/74102/diff/1/
Testing
-------
Thanks,
Mandar Ambawane
Re: Review Request 74102: ATLAS-4666 : Intermittently, the audits for creation of hive_db registered are different than expected
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
> On Oct. 7, 2022, 4:23 a.m., Sidharth Mishra wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
> > Lines 659 (patched)
> > <https://reviews.apache.org/r/74102/diff/1/?file=2269810#file2269810line659>
> >
> > If someone set "atlas.rest.create.shell.entity.for.non-existing.ref" to true and used REST calls to create entities, it might end up creating multiple create audit records. Please try testing this. If it does I need to see how to fix this and have only one create entry.
Hi Sidharth, we checked by setting this property "true" and creating Hive table entity from Atlas UI. Only one "Create" Audit entry got generated.
- Mandar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74102/#review224762
-----------------------------------------------------------
On Sept. 6, 2022, 5:16 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74102/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2022, 5:16 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Pinal Shah, Radhika Kundam, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4666
> https://issues.apache.org/jira/browse/ATLAS-4666
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Sometimes, when I create a hive database and then check for the same in Atlas, the audits tab shows unexpected audit entries: it shows two audit entries both marked as 'Entity Updated' rather than showing a 'Entity Created' audit entry anywhere.
>
> This patch will check for the Shell entities created and then assign the Entity status to the Audit entry.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java d48c91709
>
>
> Diff: https://reviews.apache.org/r/74102/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 74102: ATLAS-4666 : Intermittently, the audits for creation of hive_db registered are different than expected
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74102/#review224762
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
Lines 659 (patched)
<https://reviews.apache.org/r/74102/#comment313568>
If someone set "atlas.rest.create.shell.entity.for.non-existing.ref" to true and used REST calls to create entities, it might end up creating multiple create audit records. Please try testing this. If it does I need to see how to fix this and have only one create entry.
- Sidharth Mishra
On Sept. 6, 2022, 5:16 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74102/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2022, 5:16 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Pinal Shah, Radhika Kundam, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4666
> https://issues.apache.org/jira/browse/ATLAS-4666
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Sometimes, when I create a hive database and then check for the same in Atlas, the audits tab shows unexpected audit entries: it shows two audit entries both marked as 'Entity Updated' rather than showing a 'Entity Created' audit entry anywhere.
>
> This patch will check for the Shell entities created and then assign the Entity status to the Audit entry.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java d48c91709
>
>
> Diff: https://reviews.apache.org/r/74102/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mandar Ambawane
>
>
Re: Review Request 74102: ATLAS-4666 : Intermittently, the audits for creation of hive_db registered are different than expected
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74102/#review224813
-----------------------------------------------------------
Ship it!
Ship It!
- Sidharth Mishra
On Sept. 6, 2022, 5:16 a.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74102/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2022, 5:16 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Pinal Shah, Radhika Kundam, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4666
> https://issues.apache.org/jira/browse/ATLAS-4666
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Sometimes, when I create a hive database and then check for the same in Atlas, the audits tab shows unexpected audit entries: it shows two audit entries both marked as 'Entity Updated' rather than showing a 'Entity Created' audit entry anywhere.
>
> This patch will check for the Shell entities created and then assign the Entity status to the Audit entry.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java d48c91709
>
>
> Diff: https://reviews.apache.org/r/74102/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mandar Ambawane
>
>