You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/01 11:40:04 UTC
[GitHub] [doris] morrySnow opened a new pull request, #10550: [enhancement](Nereids)make nereids work
morrySnow opened a new pull request, #10550:
URL: https://github.com/apache/doris/pull/10550
# Proposed changes
Nereids could execute query: `select a from t;`
**enhancement**
- add a queriable interface for QueryStmt and LogicalPlanAdapter Temporarily
- refactor GroupId, GroupId extends doris.common.id now
- GroupId is generated by it's memo now, not global yet
- add varchar type
- Nereids enabled only when vectorized engine enabled
**fix**
- set output and column label to logicalPlanAdapter
- set output expression on root fragment
- set select partition and select index id to OlapScanNode
- BatchRulesJob add rule type mismatch
- add all implementation rules to rule set
- SlotReference get catalog column no longer returns null values
**known issue**
- ShowStmt and DdlStmt could not work when enable nereids
- could not do select *
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No
3. Has document been added or modified: NoNeed
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10550: [enhancement](Nereids)make nereids work
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #10550:
URL: https://github.com/apache/doris/pull/10550#discussion_r912596824
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -358,7 +358,12 @@ public void init(Analyzer analyzer) throws UserException {
}
public void init() throws UserException {
Review Comment:
Add a comment to explain `This function is only used for nereids `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #10550: [enhancement](Nereids)make nereids work
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10550:
URL: https://github.com/apache/doris/pull/10550#discussion_r912600700
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -358,7 +358,12 @@ public void init(Analyzer analyzer) throws UserException {
}
public void init() throws UserException {
Review Comment:
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] EmmyMiao87 merged pull request #10550: [enhancement](Nereids)make nereids work
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #10550:
URL: https://github.com/apache/doris/pull/10550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #10550: [enhancement](Nereids)make nereids work
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10550:
URL: https://github.com/apache/doris/pull/10550#discussion_r911904607
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -169,6 +172,12 @@ public PlanFragment visitPhysicalOlapScan(
TableRef ref = new TableRef(tableName, null, null);
BaseTableRef tableRef = new BaseTableRef(ref, olapTable, tableName);
tupleDescriptor.setRef(tableRef);
+ olapScanNode.setSelectedPartitionIds(physicalOlapScan.getSelectedPartitionId());
+ try {
+ olapScanNode.updateScanRangeInfoByNewMVSelector(physicalOlapScan.getSelectedIndexId(), false, "");
+ } catch (Exception e) {
+ LOG.warn("set failed", e);
Review Comment:
what happens when an exception is caught? compute wrong result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #10550: [enhancement](Nereids)make nereids work
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10550:
URL: https://github.com/apache/doris/pull/10550#discussion_r911916054
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -169,6 +172,12 @@ public PlanFragment visitPhysicalOlapScan(
TableRef ref = new TableRef(tableName, null, null);
BaseTableRef tableRef = new BaseTableRef(ref, olapTable, tableName);
tupleDescriptor.setRef(tableRef);
+ olapScanNode.setSelectedPartitionIds(physicalOlapScan.getSelectedPartitionId());
+ try {
+ olapScanNode.updateScanRangeInfoByNewMVSelector(physicalOlapScan.getSelectedIndexId(), false, "");
+ } catch (Exception e) {
+ LOG.warn("set failed", e);
Review Comment:
change to throw exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10550: [enhancement](Nereids)make nereids work
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10550:
URL: https://github.com/apache/doris/pull/10550#issuecomment-1173394931
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10550: [enhancement](Nereids)make nereids work
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10550:
URL: https://github.com/apache/doris/pull/10550#issuecomment-1173394952
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org