You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pdion891 <gi...@git.apache.org> on 2016/03/10 03:11:45 UTC
[GitHub] cloudstack pull request: Dockerfile4.9
GitHub user pdion891 opened a pull request:
https://github.com/apache/cloudstack/pull/1435
Dockerfile4.9
* Fixed docker build for simulator, marvin and management-server.
* Fixed change of release script to update dockerfiles.
* I will update Jenkins builds once merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdion891/cloudstack dockerfile4.9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1435.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1435
----
commit 9cf4826122dc36e393fe7ca780dbe657978fe1c1
Author: Pierre-Luc Dion <pd...@apache.org>
Date: 2016-02-14T21:40:01Z
update docker files for version 4.9.0 from master branch
commit 5bf60169dad9bc7e81ee2ac7325bf7fe7092f17d
Author: Pierre-Luc Dion <pd...@apache.org>
Date: 2016-03-10T02:06:09Z
fix installation of mysql-connector-python
commit 8ecfa10364b5a1f965965cc018d8ffd809da28bb
Author: Pierre-Luc Dion <pd...@apache.org>
Date: 2016-03-10T02:08:02Z
Merge branch 'master' into dockerfile4.9
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@pdion891 if possible, I would like to get this merged for 4.9.1.0. How does this PR relate to #1789? Also, could you please investigate the Jenkins failure and create JIRA ticket for this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@pdion891 can you please investigate the Jenkins failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the issue:
https://github.com/apache/cloudstack/pull/1435
LGTM
I still think we need to put the db in another container, and start the whole thing with compose.
Also we need to make the image smaller, maybe using Debian as base would be smaller than then full ubuntu:14.04
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@runseb I agree, images must be smaller. for the simulator, it's kind of usefull to have everything in it but it's not container best practice for sure. other images, we could probably use alpine linux, but still need to figure out how to run cloudstack as a single .war file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@jburwell good to have this, not sure how many people maybe using container/docker based mgmt servers?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1435: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 closed the pull request at:
https://github.com/apache/cloudstack/pull/1435
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1435
Hi @jburwell, do you think we can merge this in master or you are in a code freeze for 4.10.0.0 ?
Thanks,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1435
I've retested the management server, it work with Jenkins as the build is back online.
@jburwell, do you know if there is a way to squash a commit within the same PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@swill, @runseb does one of you could LGTM or comment thanks,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@rhtyd agreed. I apologize for being unclear -- I would like to get this PR into 4.9.1.0, but it is not a release blocker.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@pdion891 this [blog](https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/) is good description of squash process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1435#discussion_r65109952
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -18,14 +18,16 @@
FROM centos:6
MAINTAINER "Apache CloudStack" <de...@cloudstack.apache.org>
-LABEL Vendor="Apache.org" License="ApacheV2" Version="4.6.0"
+LABEL Vendor="Apache.org" License="ApacheV2" Version="4.9.0-SNAPSHOT"
-ENV PKG_URL=http://jenkins.buildacloud.org/job/package-rhel63-master/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
+ENV PKG_URL=http://74.121.245.247/job/package-master-rhel63/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
--- End diff --
@rhtyd, @swill I know this is wrong, but the new URL is not live yet: builds.cloudstack.org so either we merge this and I'll update it at some point or we just cancel this PR until the URL go live ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the issue:
https://github.com/apache/cloudstack/pull/1435
I used it for development and testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1435
This PR is not valid anymore replaced by Squashed: #1815
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1435#discussion_r65180940
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -18,14 +18,16 @@
FROM centos:6
MAINTAINER "Apache CloudStack" <de...@cloudstack.apache.org>
-LABEL Vendor="Apache.org" License="ApacheV2" Version="4.6.0"
+LABEL Vendor="Apache.org" License="ApacheV2" Version="4.9.0-SNAPSHOT"
-ENV PKG_URL=http://jenkins.buildacloud.org/job/package-rhel63-master/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
+ENV PKG_URL=http://74.121.245.247/job/package-master-rhel63/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
--- End diff --
@rhtyd I've create you an account on the Jenkins server. not a lot of jobs are there yet.
Lets continue the discussion on slack...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@PaulAngus @rhtyd what are your thoughts on automating the testing of the Docker container?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dockerfile4.9
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1435#discussion_r65123586
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -18,14 +18,16 @@
FROM centos:6
MAINTAINER "Apache CloudStack" <de...@cloudstack.apache.org>
-LABEL Vendor="Apache.org" License="ApacheV2" Version="4.6.0"
+LABEL Vendor="Apache.org" License="ApacheV2" Version="4.9.0-SNAPSHOT"
-ENV PKG_URL=http://jenkins.buildacloud.org/job/package-rhel63-master/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
+ENV PKG_URL=http://74.121.245.247/job/package-master-rhel63/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
--- End diff --
I'm fine with either ways, is the jenkins server on this IP public and can we have accounts on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1435
### ACS CI BVT Run
**Sumarry:**
Build Number 146
Hypervisor xenserver
NetworkType Advanced
Passed=68
Failed=5
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_vpc_vpn.py
* ContextSuite context=TestRVPCSite2SiteVpn>:setup Failing since 11 runs
* ContextSuite context=TestVpcRemoteAccessVpn>:setup Failing since 11 runs
* ContextSuite context=TestVpcSite2SiteVpn>:setup Failing since 11 runs
* test_volumes.py
* test_06_download_detached_volume Failed
* test_vm_life_cycle.py
* test_10_attachAndDetach_iso Failed
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1435: Dockerfile4.9
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@resmo I've updated the PR. I've tested the simulator and marvin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dockerfile4.9
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1435#issuecomment-216225313
@pdion891 rebase against latest master and squash commits into a single commit, thanks
LGTM
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---