You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by chitin <gi...@git.apache.org> on 2016/09/23 09:41:36 UTC
[GitHub] incubator-eagle pull request #451: EAGLE-565 Because of the "type" field whe...
GitHub user chitin opened a pull request:
https://github.com/apache/incubator-eagle/pull/451
EAGLE-565 Because of the "type" field when has subqueue ,response of RM REST API doesn\u2018t match the SchedulerWrapper object
EAGLE-565 Because of the "type" field when has subqueue ,response of RM REST API doesn\u2018t match the SchedulerWrapper object
- remove the "type" field in class Queue.
https://issues.apache.org/jira/browse/EAGLE-565
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chitin/incubator-eagle master565
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #451
----
commit bcfb2ef2b853cec8a541bb4801d4b14d9197a516
Author: chitin <ch...@gmail.com>
Date: 2016-09-23T09:29:45Z
EAGLE-565 Because of the "type" field when has subqueue ,response of RM REST API doesn�t match the SchedulerWrapper object
- remove the "type" field in class Queue.
https://issues.apache.org/jira/browse/EAGLE-565
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #451: EAGLE-565 Because of the "type" field whe...
Posted by chitin <gi...@git.apache.org>.
Github user chitin closed the pull request at:
https://github.com/apache/incubator-eagle/pull/451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #451: EAGLE-565 Because of the "type" field whe...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/451#discussion_r80310599
--- Diff: eagle-jpm/eagle-hadoop-queue/src/main/java/org/apache/eagle/hadoop/queue/model/scheduler/Queue.java ---
@@ -24,7 +24,6 @@
@JsonSerialize(include = JsonSerialize.Inclusion.NON_NULL)
@JsonIgnoreProperties(ignoreUnknown = true)
public class Queue {
- private String type;
--- End diff --
can you comment this field rather than removing it, also adding the explanation I provided in the EAGLE-561 ? that would be helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---