You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/01 23:45:07 UTC
[GitHub] [incubator-superset] junlincc opened a new issue #12233: [Explore]Data panel Metrics section should expand on click the caret
junlincc opened a new issue #12233:
URL: https://github.com/apache/incubator-superset/issues/12233
Current behavior
1. Data panel shows first 50 columns in Columns section, and the section is open by default; Users have to scroll down to get to the Metrics section
2. Metrics section is closed by default; Users click the caret to open Metrics section
3. Section opens below but it is not expanded visibly; users have to scroll down to see Metrics list
4. After scrolling down to view metrics, repeat the action, section now expands
Expected
Data panel Metrics section should expand after the first click on caret without user scrolling down.
https://user-images.githubusercontent.com/67837651/103448009-2b22f680-4c48-11eb-962c-36b74bb4f864.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie commented on issue #12233: [Explore]Data panel Metrics section should expand on click the caret
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #12233:
URL: https://github.com/apache/incubator-superset/issues/12233#issuecomment-754418309
- displaying many dimensions and metrics will affect the rendering efficiency
- but we should use other methods to control whether this data source displays these fields or not (e.g. add an option to control dimensions/metrics visible in explore)
- Before extra-control is done, it makes sense to expand both dimensions/metrics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12233: [Explore]Data panel Metrics section should expand on click the caret
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12233:
URL: https://github.com/apache/incubator-superset/issues/12233#issuecomment-754409404
or maybe we should keep both sections open by default if it does not affect performance? @zhaoyongjie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12233: [Explore]Data panel Metrics section should expand on click the caret
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12233:
URL: https://github.com/apache/incubator-superset/issues/12233#issuecomment-754430574
I would not recommend compromising the performance to favor UX for this one. do you think we can address the original issue i filed for now? which is click to auto expand Metrics section? @zhaoyongjie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie edited a comment on issue #12233: [Explore]Data panel Metrics section should expand on click the caret
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on issue #12233:
URL: https://github.com/apache/incubator-superset/issues/12233#issuecomment-754418309
@junlincc
- displaying many dimensions and metrics will affect the rendering efficiency
- but we should use other methods to control whether this data source displays these fields or not (e.g. add an option to control dimensions/metrics visible in explore)
- Before extra-control is done, it makes sense to expand both dimensions/metrics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org