You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2019/12/04 18:33:00 UTC
[jira] [Commented] (RATIS-767) DirectByteBuffers leaked by
BufferedWriteChannel in SegmentRaftLog
[ https://issues.apache.org/jira/browse/RATIS-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988079#comment-16988079 ]
Hadoop QA commented on RATIS-767:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 27s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 26s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 26s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 30s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 44s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2019-12-04 |
| JIRA Issue | RATIS-767 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987495/RATIS-767.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 4a21f24a39dc 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh |
| git revision | master / 22ceab2 |
| maven | version: Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| mvninstall | https://builds.apache.org/job/PreCommit-RATIS-Build/1178/artifact/out/patch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/PreCommit-RATIS-Build/1178/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/PreCommit-RATIS-Build/1178/artifact/out/patch-compile-root.txt |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/1178/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/1178/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-RATIS-Build/1178/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 85 (vs. ulimit of 5000) |
| modules | C: ratis-server U: ratis-server |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/1178/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> DirectByteBuffers leaked by BufferedWriteChannel in SegmentRaftLog
> ------------------------------------------------------------------
>
> Key: RATIS-767
> URL: https://issues.apache.org/jira/browse/RATIS-767
> Project: Ratis
> Issue Type: Bug
> Components: server
> Reporter: Rajesh Balamohan
> Assignee: Mukul Kumar Singh
> Priority: Major
> Attachments: RATIS-767.001.patch, Screenshot 2019-10-25 at 12.20.05 PM.png
>
>
> As noticed by Rajesh, Ratis is leaking DirectByteBuffers in BufferedWriteChannel.
> As has been shared in multiple articles on the internet, it is best to allocate pool of direct byte buffers and use them from the pool. Please refer : https://www.javamex.com/tutorials/io/nio_buffer_direct.shtml
> This jira introduces a BufferPool to avoid memory leaks
> !Screenshot 2019-10-25 at 12.20.05 PM.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)