Re: [PR] NO-ISSUE: pin Maven version in mvnw bootstrap via build-dependencies-versions.json [incubator-kie-tools]

["tiagobento (via GitHub)" <gi...@apache.org>]

tiagobento commented on code in PR #3679:
URL: https://github.com/apache/incubator-kie-tools/pull/3679#discussion_r3640906203


##########
packages/maven-base/env/index.js:
##########
@@ -18,6 +18,7 @@
  */
 
 const { varsWithName, composeEnv, getOrDefault } = require("@kie-tools-scripts/build-env");
+const buildDeps = require("../../../repo/build-dependencies-versions.json");

Review Comment:
   I'm not the biggest fan of this reference here. I understand why you did this, but I guess the env/index.js file should actually be the source of truth. And the `../../../repo/build-dependencies-versions.json` shouldn't exist in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org