You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2016/03/08 12:43:04 UTC
lucene-solr git commit: LUCENE-7077: fail precommit on useless
assignment
Repository: lucene-solr
Updated Branches:
refs/heads/master 5bb072d4b -> bfd58bc9d
LUCENE-7077: fail precommit on useless assignment
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/bfd58bc9
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/bfd58bc9
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/bfd58bc9
Branch: refs/heads/master
Commit: bfd58bc9defc85fd4669885329dbfd259fcc118a
Parents: 5bb072d
Author: Robert Muir <rm...@apache.org>
Authored: Tue Mar 8 06:42:35 2016 -0500
Committer: Robert Muir <rm...@apache.org>
Committed: Tue Mar 8 06:42:35 2016 -0500
----------------------------------------------------------------------
.../src/java/org/apache/lucene/codecs/memory/FSTTermsWriter.java | 2 +-
lucene/tools/javadoc/ecj.javadocs.prefs | 2 +-
.../src/test/org/apache/solr/update/DirectUpdateHandlerTest.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/bfd58bc9/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsWriter.java
----------------------------------------------------------------------
diff --git a/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsWriter.java b/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsWriter.java
index 50044f1..8284d74 100644
--- a/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsWriter.java
+++ b/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsWriter.java
@@ -167,7 +167,7 @@ public class FSTTermsWriter extends FieldsConsumer {
FieldInfo fieldInfo = fieldInfos.fieldInfo(field);
boolean hasFreq = fieldInfo.getIndexOptions().compareTo(IndexOptions.DOCS_AND_FREQS) >= 0;
TermsEnum termsEnum = terms.iterator();
- TermsWriter termsWriter = termsWriter = new TermsWriter(fieldInfo);
+ TermsWriter termsWriter = new TermsWriter(fieldInfo);
long sumTotalTermFreq = 0;
long sumDocFreq = 0;
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/bfd58bc9/lucene/tools/javadoc/ecj.javadocs.prefs
----------------------------------------------------------------------
diff --git a/lucene/tools/javadoc/ecj.javadocs.prefs b/lucene/tools/javadoc/ecj.javadocs.prefs
index 63f22e6..d01148c 100644
--- a/lucene/tools/javadoc/ecj.javadocs.prefs
+++ b/lucene/tools/javadoc/ecj.javadocs.prefs
@@ -51,7 +51,7 @@ org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=ignore
org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
-org.eclipse.jdt.core.compiler.problem.noEffectAssignment=ignore
+org.eclipse.jdt.core.compiler.problem.noEffectAssignment=error
org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=ignore
org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
org.eclipse.jdt.core.compiler.problem.nullReference=ignore
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/bfd58bc9/solr/core/src/test/org/apache/solr/update/DirectUpdateHandlerTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/update/DirectUpdateHandlerTest.java b/solr/core/src/test/org/apache/solr/update/DirectUpdateHandlerTest.java
index d35614d..2bde118 100644
--- a/solr/core/src/test/org/apache/solr/update/DirectUpdateHandlerTest.java
+++ b/solr/core/src/test/org/apache/solr/update/DirectUpdateHandlerTest.java
@@ -299,7 +299,7 @@ public class DirectUpdateHandlerTest extends SolrTestCaseJ4 {
assertU(commit("expungeDeletes","true"));
sr = req("q","foo");
- r = r = sr.getSearcher().getIndexReader();
+ r = sr.getSearcher().getIndexReader();
assertEquals(r.maxDoc(), r.numDocs()); // no deletions
assertEquals(4,r.maxDoc()); // no dups
sr.close();