You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacopo Cappellato (JIRA)" <ji...@ofbiz.org> on 2006/09/12 09:13:12 UTC

[JIRA] Commented: (OFBIZ-82) protect the member variables in ContainerConfig, and use better OO separation

     [ http://jira.undersunconsulting.com/browse/OFBIZ-82?page=comments#action_13837 ]
     
Jacopo Cappellato commented on OFBIZ-82:
----------------------------------------

Is it something we should include now? Since the patch is probably old now (and its application could fail) we could close this issue and maybe get a new one in the future from Adam.

> protect the member variables in ContainerConfig, and use better OO separation
> -----------------------------------------------------------------------------
>
>          Key: OFBIZ-82
>          URL: http://jira.undersunconsulting.com/browse/OFBIZ-82
>      Project: [OFBiz] Open For Business
>         Type: Improvement
>     Versions: SVN
>     Reporter: Adam Heath
>     Assignee: Jira Administrator
>     Priority: Minor
>      Fix For: SVN
>  Attachments: oo-sep.patch
>
>
> The fields in the property/container classes are public.  This is poor OO design.  The attached patch changes all code to use accessor methods to get the data.  This is needed for a later patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.undersunconsulting.com/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira