[GitHub] [brooklyn-docs] tbouron edited a comment on issue #284: Add Dockerfile to build the website with docker

[GitBox <gi...@apache.org>]

tbouron edited a comment on issue #284: Add Dockerfile to build the website with docker
URL: https://github.com/apache/brooklyn-docs/pull/284#issuecomment-482493728
 
 
   @geomacy Adding
   ```
   WORKDIR /usr/workspace
   
   COPY Gemfile .
   COPY Gemfile.lock .
   RUN /bin/bash -l -c "bundle install"
   ```
   is a brilliant idea, don't know why I didn't do it in the first place! Re warning message, bundler says: `Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break this application for all non-root users on this machine.`. In this case, it's fine as we don't care about the other users.
   
   Then I looked at how to build the stuff as the current user but it seems that docker does the right thing:
   ```
    ~/repositories/brooklyn/brooklyn-docs   website-docker ± ls -la _site
   total 144
   drwxr-xr-x  15 thomasbouron  staff    480 Apr 12 09:12 .
   drwxr-xr-x  30 thomasbouron  staff    960 Apr 12 09:42 ..
   -rw-r--r--   1 thomasbouron  staff    678 Apr 12 09:12 Dockerfile
   -rw-r--r--   1 thomasbouron  staff  34981 Apr 12 09:12 LICENSE
   -rw-r--r--   1 thomasbouron  staff    169 Apr 12 09:12 NOTICE
   drwxr-xr-x   8 thomasbouron  staff    256 Apr 12 09:12 community
   drwxr-xr-x   6 thomasbouron  staff    192 Apr 12 09:12 contributing
   drwxr-xr-x  12 thomasbouron  staff    384 Apr 12 09:12 developers
   drwxr-xr-x   6 thomasbouron  staff    192 Apr 12 09:12 documentation
   drwxr-xr-x   4 thomasbouron  staff    128 Apr 12 09:12 download
   -rw-r--r--   1 thomasbouron  staff   1150 Apr 12 09:12 favicon.ico
   -rw-r--r--   1 thomasbouron  staff  22911 Apr 12 09:12 index.html
   drwxr-xr-x   7 thomasbouron  staff    224 Apr 12 09:12 learnmore
   drwxr-xr-x   5 thomasbouron  staff    160 Apr 12 09:12 meta
   drwxr-xr-x   6 thomasbouron  staff    192 Apr 12 09:12 style
   ```
   
   Does it looks correct to you @geomacy @m4rkmckenna @johnmccabe ? I'll push an update

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services