You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/09/19 17:00:37 UTC

[GitHub] [thrift] fishy commented on a change in pull request #2455: Modified build tags to allow js/wasm target

fishy commented on a change in pull request #2455:
URL: https://github.com/apache/thrift/pull/2455#discussion_r711773344



##########
File path: lib/go/thrift/socket_windows_conn.go
##########
@@ -1,4 +1,4 @@
-// +build windows
+// +build windows wasm

Review comment:
       with this change it's better to rename the file as well. maybe `socket_non_unix_conn.go`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org