You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/04 10:35:38 UTC
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #896: MINIFICPP-1353 Fix a heap-use-after-free error
fgerlits opened a new pull request #896:
URL: https://github.com/apache/nifi-minifi-cpp/pull/896
https://issues.apache.org/jira/browse/MINIFICPP-1353
Declare the variables in the right order in `InvokeHTTP::onTrigger()` to make sure that the destructors run in the right order.
In the long term, the client should probably own the callbacks (and callbacks should own their sub-callbacks), but that would be a bigger change, and is less important.
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #896: MINIFICPP-1353 Fix a heap-use-after-free error
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #896:
URL: https://github.com/apache/nifi-minifi-cpp/pull/896#discussion_r483587276
##########
File path: extensions/http-curl/processors/InvokeHTTP.cpp
##########
@@ -283,6 +283,10 @@ void InvokeHTTP::onTrigger(const std::shared_ptr<core::ProcessContext> &context,
// create a transaction id
std::string tx_id = generateId();
+ std::unique_ptr<utils::ByteInputCallBack> callback = nullptr;
+ std::unique_ptr<utils::HTTPUploadCallback> callbackObj = nullptr;
+
+ // Client declared after the callbacks to make sure the callbacks are still available when the client is destructed
Review comment:
Good point, I have added a comment. This is a good example when a comment is necessary, but it is also a code smell. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #896: MINIFICPP-1353 Fix a heap-use-after-free error
Posted by GitBox <gi...@apache.org>.
hunyadi-dev commented on a change in pull request #896:
URL: https://github.com/apache/nifi-minifi-cpp/pull/896#discussion_r483574962
##########
File path: extensions/http-curl/processors/InvokeHTTP.cpp
##########
@@ -283,6 +283,10 @@ void InvokeHTTP::onTrigger(const std::shared_ptr<core::ProcessContext> &context,
// create a transaction id
std::string tx_id = generateId();
+ std::unique_ptr<utils::ByteInputCallBack> callback = nullptr;
+ std::unique_ptr<utils::HTTPUploadCallback> callbackObj = nullptr;
+
+ // Client declared after the callbacks to make sure the callbacks are still available when the client is destructed
Review comment:
Might be worth mentioning that the destruction of `callback` and `callbackObj` also matters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #896: MINIFICPP-1353 Fix a heap-use-after-free error
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #896:
URL: https://github.com/apache/nifi-minifi-cpp/pull/896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org