You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/24 12:57:12 UTC
[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1342: HDDS-4135: In ContainerStateManagerV2, modification of RocksDB should be consistent with that of memory state.
GlenGeng opened a new pull request #1342:
URL: https://github.com/apache/hadoop-ozone/pull/1342
## What changes were proposed in this pull request?
Fix a bug in https://issues.apache.org/jira/browse/HDDS-3895
In ContainerStateManagerV2, both disk state (column families in RocksDB) and memory state (container maps in memory) are protected by raft, and should keep their consistency upon each modification.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4135
Please replace this section with the link to the Apache JIRA)
CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] GlenGeng commented on a change in pull request #1342: HDDS-4135: In ContainerStateManagerV2, modification of RocksDB should be consistent with that of memory state.
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #1342:
URL: https://github.com/apache/hadoop-ozone/pull/1342#discussion_r481833398
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java
##########
@@ -334,8 +347,12 @@ ContainerInfo getMatchingContainer(final long size, String owner,
throw new UnsupportedOperationException("Not yet implemented!");
}
- public void removeContainer(final HddsProtos.ContainerID id) {
- containers.removeContainer(ContainerID.getFromProtobuf(id));
+ @Override
+ public void removeContainer(final HddsProtos.ContainerID id)
Review comment:
we can verify the state of memory and RocksDB in Unit Test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1342: HDDS-4135: In ContainerStateManagerV2, modification of RocksDB should be consistent with that of memory state.
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #1342:
URL: https://github.com/apache/hadoop-ozone/pull/1342#issuecomment-685411704
Close this PR, since @nandakumar131 would fix this issue in his future PR for container V2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on a change in pull request #1342: HDDS-4135: In ContainerStateManagerV2, modification of RocksDB should be consistent with that of memory state.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1342:
URL: https://github.com/apache/hadoop-ozone/pull/1342#discussion_r480481261
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java
##########
@@ -334,8 +347,12 @@ ContainerInfo getMatchingContainer(final long size, String owner,
throw new UnsupportedOperationException("Not yet implemented!");
}
- public void removeContainer(final HddsProtos.ContainerID id) {
- containers.removeContainer(ContainerID.getFromProtobuf(id));
+ @Override
+ public void removeContainer(final HddsProtos.ContainerID id)
Review comment:
So there is no easy way to test such changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] GlenGeng closed pull request #1342: HDDS-4135: In ContainerStateManagerV2, modification of RocksDB should be consistent with that of memory state.
Posted by GitBox <gi...@apache.org>.
GlenGeng closed pull request #1342:
URL: https://github.com/apache/hadoop-ozone/pull/1342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org