[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3899: [Sharding Scaling]Refactor to support PostgreSQL

[GitBox <gi...@apache.org>]

KomachiSion commented on a change in pull request #3899: [Sharding Scaling]Refactor to support PostgreSQL
URL: https://github.com/apache/incubator-shardingsphere/pull/3899#discussion_r364519005
 
 

 ##########
 File path: sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/writer/SqlBuilder.java
 ##########
 @@ -20,33 +20,28 @@
 import com.google.common.cache.CacheBuilder;
 import com.google.common.cache.CacheLoader;
 import com.google.common.cache.LoadingCache;
+import org.apache.shardingsphere.shardingscaling.core.metadata.ColumnMetaData;
+import org.apache.shardingsphere.shardingscaling.core.util.DbMetaDataUtil;
 
 import javax.sql.DataSource;
 import java.util.List;
 import java.util.concurrent.ExecutionException;
 
-import org.apache.shardingsphere.shardingscaling.core.util.DbMetaDataUtil;
-import org.apache.shardingsphere.shardingscaling.core.metadata.ColumnMetaData;
-
 /**
  * Sql builder.
  *
  * @author avalon566
  */
-public final class SqlBuilder {
-    
-    private static final String LEFT_ESCAPE_QUOTE = "`";
-
-    private static final String RIGHT_ESCAPE_QUOTE = "`";
+public abstract class SqlBuilder {
 
 Review comment:
   Should we rename the class?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services