You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by nickwallen <gi...@git.apache.org> on 2018/11/14 15:22:48 UTC
[GitHub] metron pull request #1262: METRON-1871 Cannot Run Elasticsearch Integration ...
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1262
METRON-1871 Cannot Run Elasticsearch Integration Tests in IDE
There are some log4j dependencies in the metron-elasticsearch that cause problems when attempting to run the Elasticsearch integration tests from an IDE like Intellij. These dependencies are unnecessary and should be removed for that reason alone. But additionally this fix lets you run the tests from Intellij.
This was previously included in #1218 before that was backed out of master.
## Testing
1. Load up the code in an IDE like IntelliJ.
1. Execute the tests in `metron-platform/metron-elasticsearch/src/tests`.
1. The tests should all run successfully.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1871
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1262
----
commit f101ab74fe23c5bfbbc822e787c43984d0dbef8f
Author: Nick Allen <ni...@...>
Date: 2018-11-14T15:18:09Z
METRON-1871 Cannot Run Elasticsearch Integration Tests in IDE
----
---
[GitHub] metron pull request #1262: METRON-1871 Cannot Run Elasticsearch Integration ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/1262
---
[GitHub] metron issue #1262: METRON-1871 Cannot Run Elasticsearch Integration Tests i...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1262
I find myself commenting these out every time I run ES integration tests in my IDE. +1
---
[GitHub] metron issue #1262: METRON-1871 Cannot Run Elasticsearch Integration Tests i...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1262
This was taken care of in #1242 . No need.
---