You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/31 02:54:26 UTC

[GitHub] [incubator-inlong] healchow opened a new pull request, #4449: [INLONG-4447][Manager] Replace the InlongStreamConf with InlongStreamInfo for manager-client

healchow opened a new pull request, #4449:
URL: https://github.com/apache/incubator-inlong/pull/4449

   ### Title Name: [INLONG-4447][Manager] Replace the InlongStreamConf with InlongStreamInfo for manager-client
   
   Fixes #4447
   
   ### Motivation
   
   Replace the InlongStreamConf with InlongStreamInfo for manager-client.
   
   ### Modifications
   
   1. Remove InlongStreamConf class.
   2. Use InlongStreamInfo instead of InlongStreamConf.
   
   ### Verifying this change
   
   - [X] This change is a trivial rework/code cleanup without any test coverage.
   
   ### Documentation
   
     - Does this pull request introduces a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4449: [INLONG-4447][Manager] Replace the InlongStreamConf with InlongStreamInfo for manager-client

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4449:
URL: https://github.com/apache/incubator-inlong/pull/4449#discussion_r885181930


##########
inlong-manager/manager-client-examples/src/test/java/org/apache/inlong/manager/client/BaseExample.java:
##########
@@ -92,6 +96,23 @@ public InlongGroupInfo createGroupInfo() {
         return pulsarInfo;
     }
 
+    /**
+     * Create inlong stream info
+     */
+    public InlongStreamInfo createStreamInfo() {
+        InlongStreamInfo streamInfo = new InlongStreamInfo();
+        streamInfo.setName(this.getStreamId());
+        streamInfo.setDataEncoding(StandardCharsets.UTF_8.toString());
+        streamInfo.setDataSeparator(DataSeparator.VERTICAL_BAR.getSeparator());
+        // if you need strictly order for data, set to 1
+        streamInfo.setSyncSend(1);

Review Comment:
   resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow merged pull request #4449: [INLONG-4447][Manager] Replace the InlongStreamConf with InlongStreamInfo for manager-client

Posted by GitBox <gi...@apache.org>.
healchow merged PR #4449:
URL: https://github.com/apache/incubator-inlong/pull/4449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] EMsnap commented on a diff in pull request #4449: [INLONG-4447][Manager] Replace the InlongStreamConf with InlongStreamInfo for manager-client

Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #4449:
URL: https://github.com/apache/incubator-inlong/pull/4449#discussion_r885170992


##########
inlong-manager/manager-client-examples/src/test/java/org/apache/inlong/manager/client/BaseExample.java:
##########
@@ -92,6 +96,23 @@ public InlongGroupInfo createGroupInfo() {
         return pulsarInfo;
     }
 
+    /**
+     * Create inlong stream info
+     */
+    public InlongStreamInfo createStreamInfo() {
+        InlongStreamInfo streamInfo = new InlongStreamInfo();
+        streamInfo.setName(this.getStreamId());
+        streamInfo.setDataEncoding(StandardCharsets.UTF_8.toString());
+        streamInfo.setDataSeparator(DataSeparator.VERTICAL_BAR.getSeparator());
+        // if you need strictly order for data, set to 1
+        streamInfo.setSyncSend(1);

Review Comment:
   magic num



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org