You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Michael McCandless <lu...@mikemccandless.com> on 2009/09/24 11:56:07 UTC
Re: [jira] Assigned: (LUCENE-1925) In IndexSearcher class, make
subReader and docCount arrays protected so sub classes can access them
Mark is it OK to commit this now?
When we branch 2.9 we can base it off the trunk rev before this (and
other) changes. (Ie not need to freeze trunk development). The base
of the branch should be the rev you when building the last RC.
Mike
On Thu, Sep 24, 2009 at 5:52 AM, Michael McCandless (JIRA)
<ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Michael McCandless reassigned LUCENE-1925:
> ------------------------------------------
>
> Assignee: Michael McCandless
>
>> In IndexSearcher class, make subReader and docCount arrays protected so sub classes can access them
>> ---------------------------------------------------------------------------------------------------
>>
>> Key: LUCENE-1925
>> URL: https://issues.apache.org/jira/browse/LUCENE-1925
>> Project: Lucene - Java
>> Issue Type: Improvement
>> Components: Search
>> Affects Versions: 2.9
>> Reporter: John Wang
>> Assignee: Michael McCandless
>>
>> Please make these two member variables protected so subclasses can access them, e.g.:
>> protected IndexReader[] subReaders;
>> protected int[] docStarts;
>> Thanks
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Assigned: (LUCENE-1925) In IndexSearcher class, make
subReader and docCount arrays protected so sub classes can access them
Posted by Michael McCandless <lu...@mikemccandless.com>.
OK I did this, and added the "unreleased" section into contrib/CHANGES.txt.
Mike
On Thu, Sep 24, 2009 at 5:19 PM, Michael McCandless
<lu...@mikemccandless.com> wrote:
> On Thu, Sep 24, 2009 at 3:38 PM, Mark Miller <ma...@gmail.com> wrote:
>> I think we need to move the Changes entry you put in though, right? Its
>> in the 2.9 section, but its not part of 2.9.
>>
>> I havn't made the new changes sections on trunk yet, but please, someone
>> feel free to beat me to. I'm going to work on publishing.
>
> Ahh yes, but only on trunk. Your 2.9 branch won't have the CHANGES entry.
>
> I'll move it.
>
>> Michael McCandless wrote:
>>> Mark is it OK to commit this now?
>>>
>>> When we branch 2.9 we can base it off the trunk rev before this (and
>>> other) changes. (Ie not need to freeze trunk development). The base
>>> of the branch should be the rev you when building the last RC.
>>>
>>> Mike
>>>
>>> On Thu, Sep 24, 2009 at 5:52 AM, Michael McCandless (JIRA)
>>> <ji...@apache.org> wrote:
>>>
>>>> [ https://issues.apache.org/jira/browse/LUCENE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>>
>>>> Michael McCandless reassigned LUCENE-1925:
>>>> ------------------------------------------
>>>>
>>>> Assignee: Michael McCandless
>>>>
>>>>
>>>>> In IndexSearcher class, make subReader and docCount arrays protected so sub classes can access them
>>>>> ---------------------------------------------------------------------------------------------------
>>>>>
>>>>> Key: LUCENE-1925
>>>>> URL: https://issues.apache.org/jira/browse/LUCENE-1925
>>>>> Project: Lucene - Java
>>>>> Issue Type: Improvement
>>>>> Components: Search
>>>>> Affects Versions: 2.9
>>>>> Reporter: John Wang
>>>>> Assignee: Michael McCandless
>>>>>
>>>>> Please make these two member variables protected so subclasses can access them, e.g.:
>>>>> protected IndexReader[] subReaders;
>>>>> protected int[] docStarts;
>>>>> Thanks
>>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> You can reply to this email to add a comment to the issue online.
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>
>>
>> --
>> - Mark
>>
>> http://www.lucidimagination.com
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Assigned: (LUCENE-1925) In IndexSearcher class, make
subReader and docCount arrays protected so sub classes can access them
Posted by Michael McCandless <lu...@mikemccandless.com>.
On Thu, Sep 24, 2009 at 3:38 PM, Mark Miller <ma...@gmail.com> wrote:
> I think we need to move the Changes entry you put in though, right? Its
> in the 2.9 section, but its not part of 2.9.
>
> I havn't made the new changes sections on trunk yet, but please, someone
> feel free to beat me to. I'm going to work on publishing.
Ahh yes, but only on trunk. Your 2.9 branch won't have the CHANGES entry.
I'll move it.
> Michael McCandless wrote:
>> Mark is it OK to commit this now?
>>
>> When we branch 2.9 we can base it off the trunk rev before this (and
>> other) changes. (Ie not need to freeze trunk development). The base
>> of the branch should be the rev you when building the last RC.
>>
>> Mike
>>
>> On Thu, Sep 24, 2009 at 5:52 AM, Michael McCandless (JIRA)
>> <ji...@apache.org> wrote:
>>
>>> [ https://issues.apache.org/jira/browse/LUCENE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>
>>> Michael McCandless reassigned LUCENE-1925:
>>> ------------------------------------------
>>>
>>> Assignee: Michael McCandless
>>>
>>>
>>>> In IndexSearcher class, make subReader and docCount arrays protected so sub classes can access them
>>>> ---------------------------------------------------------------------------------------------------
>>>>
>>>> Key: LUCENE-1925
>>>> URL: https://issues.apache.org/jira/browse/LUCENE-1925
>>>> Project: Lucene - Java
>>>> Issue Type: Improvement
>>>> Components: Search
>>>> Affects Versions: 2.9
>>>> Reporter: John Wang
>>>> Assignee: Michael McCandless
>>>>
>>>> Please make these two member variables protected so subclasses can access them, e.g.:
>>>> protected IndexReader[] subReaders;
>>>> protected int[] docStarts;
>>>> Thanks
>>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Assigned: (LUCENE-1925) In IndexSearcher class, make subReader
and docCount arrays protected so sub classes can access them
Posted by Mark Miller <ma...@gmail.com>.
I think we need to move the Changes entry you put in though, right? Its
in the 2.9 section, but its not part of 2.9.
I havn't made the new changes sections on trunk yet, but please, someone
feel free to beat me to. I'm going to work on publishing.
Michael McCandless wrote:
> Mark is it OK to commit this now?
>
> When we branch 2.9 we can base it off the trunk rev before this (and
> other) changes. (Ie not need to freeze trunk development). The base
> of the branch should be the rev you when building the last RC.
>
> Mike
>
> On Thu, Sep 24, 2009 at 5:52 AM, Michael McCandless (JIRA)
> <ji...@apache.org> wrote:
>
>> [ https://issues.apache.org/jira/browse/LUCENE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Michael McCandless reassigned LUCENE-1925:
>> ------------------------------------------
>>
>> Assignee: Michael McCandless
>>
>>
>>> In IndexSearcher class, make subReader and docCount arrays protected so sub classes can access them
>>> ---------------------------------------------------------------------------------------------------
>>>
>>> Key: LUCENE-1925
>>> URL: https://issues.apache.org/jira/browse/LUCENE-1925
>>> Project: Lucene - Java
>>> Issue Type: Improvement
>>> Components: Search
>>> Affects Versions: 2.9
>>> Reporter: John Wang
>>> Assignee: Michael McCandless
>>>
>>> Please make these two member variables protected so subclasses can access them, e.g.:
>>> protected IndexReader[] subReaders;
>>> protected int[] docStarts;
>>> Thanks
>>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Assigned: (LUCENE-1925) In IndexSearcher class, make subReader and docCount arrays protected so sub classes can access them
Posted by Mark Miller <ma...@gmail.com>.
Ok - I should have branched by now anyway - I'll do it today.
- Mark
http://www.lucidimagination.com (mobile)
On Sep 24, 2009, at 5:56 AM, Michael McCandless <lucene@mikemccandless.com
> wrote:
> Mark is it OK to commit this now?
>
> When we branch 2.9 we can base it off the trunk rev before this (and
> other) changes. (Ie not need to freeze trunk development). The base
> of the branch should be the rev you when building the last RC.
>
> Mike
>
> On Thu, Sep 24, 2009 at 5:52 AM, Michael McCandless (JIRA)
> <ji...@apache.org> wrote:
>>
>> [ https://issues.apache.org/jira/browse/LUCENE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Michael McCandless reassigned LUCENE-1925:
>> ------------------------------------------
>>
>> Assignee: Michael McCandless
>>
>>> In IndexSearcher class, make subReader and docCount arrays
>>> protected so sub classes can access them
>>> ---
>>> ---
>>> ---
>>> ---
>>> ---
>>> ---
>>> ---
>>> ---
>>> ---
>>> ---
>>> ---
>>> ------------------------------------------------------------------
>>>
>>> Key: LUCENE-1925
>>> URL: https://issues.apache.org/jira/browse/LUCENE-1925
>>> Project: Lucene - Java
>>> Issue Type: Improvement
>>> Components: Search
>>> Affects Versions: 2.9
>>> Reporter: John Wang
>>> Assignee: Michael McCandless
>>>
>>> Please make these two member variables protected so subclasses can
>>> access them, e.g.:
>>> protected IndexReader[] subReaders;
>>> protected int[] docStarts;
>>> Thanks
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org