You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/03/25 18:20:11 UTC

Review Request 70300: Cleaned up CMakeLists.txt.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70300/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Cleaned up CMakeLists.txt.


Diffs
-----

  3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
  3rdparty/Makefile.am 98a2623b34132885279bea6135c0da4ffc8c59cf 


Diff: https://reviews.apache.org/r/70300/diff/1/


Testing
-------

This review is just to trigger the windows buildbot; actual review at github: https://github.com/apache/mesos/pull/327


Thanks,

Benno Evers


Re: Review Request 70300: Cleaned up CMakeLists.txt.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70300/#review213998
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 70296.

Failed command: `python.exe .\support\apply-reviews.py -n -r 70296`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3011/mesos-review-70300

Relevant logs:

- [apply-review-70296.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3011/mesos-review-70300/logs/apply-review-70296.log):

```
70296.patch:1668: trailing whitespace.
 
70296.patch:1690: trailing whitespace.
 
70296.patch:1715: trailing whitespace.
 
70296.patch:1725: trailing whitespace.
 
error: missing binary patch data for '3rdparty/glog-0.3.5.tar.gz'
error: binary patch does not apply to '3rdparty/glog-0.3.5.tar.gz'
error: 3rdparty/glog-0.3.5.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On March 25, 2019, 6:20 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70300/
> -----------------------------------------------------------
> 
> (Updated March 25, 2019, 6:20 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up CMakeLists.txt.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/Makefile.am 98a2623b34132885279bea6135c0da4ffc8c59cf 
> 
> 
> Diff: https://reviews.apache.org/r/70300/diff/1/
> 
> 
> Testing
> -------
> 
> This review is just to trigger the windows buildbot; actual review at github: https://github.com/apache/mesos/pull/327
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 70300: Cleaned up CMakeLists.txt.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70300/#review214004
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot


On March 25, 2019, 6:20 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70300/
> -----------------------------------------------------------
> 
> (Updated March 25, 2019, 6:20 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up CMakeLists.txt.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/Makefile.am 98a2623b34132885279bea6135c0da4ffc8c59cf 
> 
> 
> Diff: https://reviews.apache.org/r/70300/diff/1/
> 
> 
> Testing
> -------
> 
> This review is just to trigger the windows buildbot; actual review at github: https://github.com/apache/mesos/pull/327
> 
> 
> Thanks,
> 
> Benno Evers
> 
>