[GitHub] [samza] Sanil15 opened a new pull request #1201: SAMZA-2361: Revert "Samza-2330: Handle expired resource request for Container allocator when host affinity is disabled"

[GitBox <gi...@apache.org>]

Sanil15 opened a new pull request #1201: SAMZA-2361: Revert "Samza-2330: Handle expired resource request for Container allocator when host affinity is disabled"
URL: https://github.com/apache/samza/pull/1201
 
 
   **Symptom:** PR #1170 introduced expired request checking for Host Affinity disabled cases, however, this leads to a few problems that we might face in future:
   1. In the scenarios of a cluster bounce, this might result in jobs (in either case of host affinity enabled & disabled cases) requesting containers from the ClusterResourceManager every 5 (default request expiry timeout) seconds if requests can't be fulfilled. Before PR #1170 this only used to happen for host affinity disabled jobs. This might potentially result in bringing down the ClusterManager. 
   2. Unless we have some performance benchmarking on RM (for Yarn as a cluster balancer), having a default expiry timeout of 5 seconds for all container requests is not justified.
   
   **Cause:** PR #1170
   
   **Fix:** We are reverting this behavior change since we have Performance benchmarking for Yarn
   
   **Tests:** Refactored test to ensure, expired requests are only checked with host affinity enabled jobs
   
   **API Changes:** N/A
   
   **Upgrade Instructions:** N/A 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services