[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #109: [YUNIKORN-14] Add rest API to retrieve app/container history info

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #109: [YUNIKORN-14] Add rest API to retrieve app/container history info
URL: https://github.com/apache/incubator-yunikorn-core/pull/109#discussion_r398258503
 
 

 ##########
 File path: pkg/cache/partition_info.go
 ##########
 @@ -103,6 +106,11 @@ func newPartitionInfo(partition configs.PartitionConfig, rmID string, info *Clus
 	// TODO get the resolver from the config
 	p.userGroupCache = security.GetUserGroupCache("")
 
+	hpInfo := &history.HistoricalPartitionInfo{}
+	p.history = hpInfo
+	p.historyUpdater = NewHistoricalPartitionInfoUpdater(p, hpInfo)
+	p.historyUpdater.Start()
+
 
 Review comment:
   Can we move this to `cluster_info.StartService()` ?
   Having a Start call in the `newPartitionInfo()` seems not appropriate. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org