You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/09/14 14:13:05 UTC
[GitHub] [skywalking-banyandb-java-client] hailin0 opened a new pull request, #47: [E2E Testing] Publish customize oap image
hailin0 opened a new pull request, #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on pull request #47: [E2E Testing] Deploy maven snapshot
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1710165306
> Why don't you build locally or during the CI, and install locally only? The ASF snapshot repo is not stable, and not immutable.
Yes, I will build a custom version OAP image at CI time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng closed pull request #47: [E2E Testing] Publish customize oap image
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #47: [E2E Testing] Publish customize oap image
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on pull request #47: [E2E Testing] Deploy maven snapshot
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1709432948
This PR will be closed after testing is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1711831802
Use CI script to build this image for BanyanDB e2e
<img width="999" alt="image" src="https://github.com/apache/skywalking-banyandb-java-client/assets/14371345/0862fd0f-ca88-4fcd-a51c-e3085c4ffc84">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #47: [E2E Testing] Publish customize oap image
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1712452290
As we had discussed, this is a one time temp publish, let's close this for now as it is published successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #47: [E2E Testing] Publish customize oap image
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1720785238
@hanahmily @lujiajing1126 Please check this.
As properties TTL feature in 0.5 is still not added, should we wait for that to do a release? Or should we run a RC release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on a diff in pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327355132
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##########
@@ -34,29 +40,50 @@
@ThreadSafe
public class StreamBulkWriteProcessor extends AbstractBulkWriteProcessor<BanyandbStream.WriteRequest,
StreamServiceGrpc.StreamServiceStub> {
+ private final BanyanDBClient client;
+
/**
* Create the processor.
*
- * @param serviceStub stub for gRPC call.
+ * @param client the client
* @param maxBulkSize the max bulk size for the flush operation
* @param flushInterval if given maxBulkSize is not reached in this period, the flush would be trigger
* automatically. Unit is second.
* @param concurrency the number of concurrency would run for the flush max.
*/
protected StreamBulkWriteProcessor(
- final StreamServiceGrpc.StreamServiceStub serviceStub,
+ final BanyanDBClient client,
final int maxBulkSize,
final int flushInterval,
final int concurrency) {
- super(serviceStub, "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ super(client.getStreamServiceStub(), "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ this.client = client;
}
@Override
protected StreamObserver<BanyandbStream.WriteRequest> buildStreamObserver(StreamServiceGrpc.StreamServiceStub stub, CompletableFuture<Void> batch) {
return stub.write(
new StreamObserver<BanyandbStream.WriteResponse>() {
+ private final Set<String> schemaExpired = new HashSet<>();
+
@Override
public void onNext(BanyandbStream.WriteResponse writeResponse) {
+ switch (writeResponse.getStatus()) {
+ case STATUS_EXPIRED_SCHEMA:
+ BanyandbCommon.Metadata metadata = writeResponse.getMetadata();
+ String schemaKey = metadata.getGroup() + "." + metadata.getName();
+ if (!schemaExpired.contains(schemaKey)) {
+ log.warn("The schema {} is expired, trying update the schema...", schemaKey);
+ try {
+ client.findStream(metadata.getGroup(), metadata.getName());
+ schemaExpired.add(schemaKey);
+ } catch (BanyanDBException e) {
+ throw new RuntimeException(e);
Review Comment:
Replace to log warning messages?
e.g
```java
String warnMessage = String.format("Failed to refresh the stream schema %s.%s",
metadata.getGroup(), metadata.getName());
log.warn(warnMessage, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #47: [E2E Testing] Publish customize oap image
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327124354
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##########
@@ -34,29 +40,50 @@
@ThreadSafe
public class StreamBulkWriteProcessor extends AbstractBulkWriteProcessor<BanyandbStream.WriteRequest,
StreamServiceGrpc.StreamServiceStub> {
+ private final BanyanDBClient client;
+
/**
* Create the processor.
*
- * @param serviceStub stub for gRPC call.
+ * @param client the client
* @param maxBulkSize the max bulk size for the flush operation
* @param flushInterval if given maxBulkSize is not reached in this period, the flush would be trigger
* automatically. Unit is second.
* @param concurrency the number of concurrency would run for the flush max.
*/
protected StreamBulkWriteProcessor(
- final StreamServiceGrpc.StreamServiceStub serviceStub,
+ final BanyanDBClient client,
final int maxBulkSize,
final int flushInterval,
final int concurrency) {
- super(serviceStub, "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ super(client.getStreamServiceStub(), "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ this.client = client;
}
@Override
protected StreamObserver<BanyandbStream.WriteRequest> buildStreamObserver(StreamServiceGrpc.StreamServiceStub stub, CompletableFuture<Void> batch) {
return stub.write(
new StreamObserver<BanyandbStream.WriteResponse>() {
+ private final Set<String> schemaExpired = new HashSet<>();
+
@Override
public void onNext(BanyandbStream.WriteResponse writeResponse) {
+ switch (writeResponse.getStatus()) {
+ case STATUS_EXPIRED_SCHEMA:
+ BanyandbCommon.Metadata metadata = writeResponse.getMetadata();
+ String schemaKey = metadata.getGroup() + "." + metadata.getName();
+ if (!schemaExpired.contains(schemaKey)) {
+ log.warn("The schema {} is expired, trying update the schema...", schemaKey);
+ try {
+ client.findStream(metadata.getGroup(), metadata.getName());
+ schemaExpired.add(schemaKey);
+ } catch (BanyanDBException e) {
+ throw new RuntimeException(e);
Review Comment:
I think we usually through banyandb exception rather than runtime exception, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #47: [E2E Testing] Publish customize oap image
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1711838448
How about skipping the publish step. Just build the container in the CI env, and run the following testing?
The main repo e2e is using one task to build binary tar and image, then share with all following CI tasks.
If we run publishing, this will become very tricky, when should build it, and who should use it after PR merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on pull request #47: [E2E Testing] Deploy maven snapshot
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1709431632
I will build a test image using this deployment
https://repository.apache.org/content/repositories/snapshots/org/apache/skywalking/banyandb-java-client/0.5.0-SNAPSHOT/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on a diff in pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327338277
##########
src/main/proto/banyandb/v1/banyandb-stream.proto:
##########
@@ -84,13 +84,22 @@ message ElementValue {
}
message WriteRequest {
- // the metadata is only required in the first write.
+ // the metadata is required.
common.v1.Metadata metadata = 1 [(validate.rules).message.required = true];
// the element is required.
ElementValue element = 2 [(validate.rules).message.required = true];
+ // the message_id is required.
+ uint64 message_id = 3 [(validate.rules).uint64.gt = 0];
}
-message WriteResponse {}
+message WriteResponse {
+ // the message_id from request.
+ uint64 message_id = 1 [(validate.rules).uint64.gt = 0];
+ // status indicates the request processing result
+ model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
+ // the metadata from request when request fails
+ common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
Review Comment:
@hanahmily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 closed pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 closed pull request #47: [E2E Testing] Publish customize oap image
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #47: [E2E Testing] Publish customize oap image
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327122199
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##########
@@ -34,29 +40,50 @@
@ThreadSafe
public class StreamBulkWriteProcessor extends AbstractBulkWriteProcessor<BanyandbStream.WriteRequest,
StreamServiceGrpc.StreamServiceStub> {
+ private final BanyanDBClient client;
+
/**
* Create the processor.
*
- * @param serviceStub stub for gRPC call.
+ * @param client the client
* @param maxBulkSize the max bulk size for the flush operation
* @param flushInterval if given maxBulkSize is not reached in this period, the flush would be trigger
* automatically. Unit is second.
* @param concurrency the number of concurrency would run for the flush max.
*/
protected StreamBulkWriteProcessor(
- final StreamServiceGrpc.StreamServiceStub serviceStub,
+ final BanyanDBClient client,
final int maxBulkSize,
final int flushInterval,
final int concurrency) {
- super(serviceStub, "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ super(client.getStreamServiceStub(), "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ this.client = client;
}
@Override
protected StreamObserver<BanyandbStream.WriteRequest> buildStreamObserver(StreamServiceGrpc.StreamServiceStub stub, CompletableFuture<Void> batch) {
return stub.write(
new StreamObserver<BanyandbStream.WriteResponse>() {
+ private final Set<String> schemaExpired = new HashSet<>();
+
@Override
public void onNext(BanyandbStream.WriteResponse writeResponse) {
+ switch (writeResponse.getStatus()) {
+ case STATUS_EXPIRED_SCHEMA:
+ BanyandbCommon.Metadata metadata = writeResponse.getMetadata();
+ String schemaKey = metadata.getGroup() + "." + metadata.getName();
+ if (!schemaExpired.contains(schemaKey)) {
+ log.warn("The schema {} is expired, trying update the schema...", schemaKey);
+ try {
+ client.findStream(metadata.getGroup(), metadata.getName());
+ schemaExpired.add(schemaKey);
+ } catch (BanyanDBException e) {
+ throw new RuntimeException(e);
Review Comment:
What would happen if we throw an exception here?
##########
src/main/proto/banyandb/v1/banyandb-stream.proto:
##########
@@ -84,13 +84,22 @@ message ElementValue {
}
message WriteRequest {
- // the metadata is only required in the first write.
+ // the metadata is required.
common.v1.Metadata metadata = 1 [(validate.rules).message.required = true];
// the element is required.
ElementValue element = 2 [(validate.rules).message.required = true];
+ // the message_id is required.
+ uint64 message_id = 3 [(validate.rules).uint64.gt = 0];
}
-message WriteResponse {}
+message WriteResponse {
+ // the message_id from request.
+ uint64 message_id = 1 [(validate.rules).uint64.gt = 0];
+ // status indicates the request processing result
+ model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
+ // the metadata from request when request fails
+ common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
Review Comment:
> // the metadata from request when request fails
So it is not required, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on pull request #47: [E2E Testing] Publish customize oap image
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1720839524
> @hanahmily @lujiajing1126 Please check this.
>
>
>
> As properties TTL feature in 0.5 is still not added, should we wait for that to do a release? Or should we run a RC release?
>
>
We will wait for the TTL to do a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #47: [E2E Testing] Deploy maven snapshot
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1709444555
Why don't you build locally or during the CI, and install locally only? The ASF snapshot repo is not stable, and not immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #47: [E2E Testing] Deploy maven snapshot
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1710169167
In that case, you don't need to deploy. You just need a local `mvn install`, and build the project based on snapshot version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1711841895
> How about skipping the publish step. Just build the container in the CI env, and run the following testing? The main repo e2e is using one task to build binary tar and image, then share with all following CI tasks.
>
> If we run publishing, this will become very tricky, when should build it, and who should use it after PR merged?
BanyanDB e2e integration test has passed, this PR will be closed later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on a diff in pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327338277
##########
src/main/proto/banyandb/v1/banyandb-stream.proto:
##########
@@ -84,13 +84,22 @@ message ElementValue {
}
message WriteRequest {
- // the metadata is only required in the first write.
+ // the metadata is required.
common.v1.Metadata metadata = 1 [(validate.rules).message.required = true];
// the element is required.
ElementValue element = 2 [(validate.rules).message.required = true];
+ // the message_id is required.
+ uint64 message_id = 3 [(validate.rules).uint64.gt = 0];
}
-message WriteResponse {}
+message WriteResponse {
+ // the message_id from request.
+ uint64 message_id = 1 [(validate.rules).uint64.gt = 0];
+ // status indicates the request processing result
+ model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
+ // the metadata from request when request fails
+ common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
Review Comment:
@hanahmily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on a diff in pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327355132
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##########
@@ -34,29 +40,50 @@
@ThreadSafe
public class StreamBulkWriteProcessor extends AbstractBulkWriteProcessor<BanyandbStream.WriteRequest,
StreamServiceGrpc.StreamServiceStub> {
+ private final BanyanDBClient client;
+
/**
* Create the processor.
*
- * @param serviceStub stub for gRPC call.
+ * @param client the client
* @param maxBulkSize the max bulk size for the flush operation
* @param flushInterval if given maxBulkSize is not reached in this period, the flush would be trigger
* automatically. Unit is second.
* @param concurrency the number of concurrency would run for the flush max.
*/
protected StreamBulkWriteProcessor(
- final StreamServiceGrpc.StreamServiceStub serviceStub,
+ final BanyanDBClient client,
final int maxBulkSize,
final int flushInterval,
final int concurrency) {
- super(serviceStub, "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ super(client.getStreamServiceStub(), "StreamBulkWriteProcessor", maxBulkSize, flushInterval, concurrency);
+ this.client = client;
}
@Override
protected StreamObserver<BanyandbStream.WriteRequest> buildStreamObserver(StreamServiceGrpc.StreamServiceStub stub, CompletableFuture<Void> batch) {
return stub.write(
new StreamObserver<BanyandbStream.WriteResponse>() {
+ private final Set<String> schemaExpired = new HashSet<>();
+
@Override
public void onNext(BanyandbStream.WriteResponse writeResponse) {
+ switch (writeResponse.getStatus()) {
+ case STATUS_EXPIRED_SCHEMA:
+ BanyandbCommon.Metadata metadata = writeResponse.getMetadata();
+ String schemaKey = metadata.getGroup() + "." + metadata.getName();
+ if (!schemaExpired.contains(schemaKey)) {
+ log.warn("The schema {} is expired, trying update the schema...", schemaKey);
+ try {
+ client.findStream(metadata.getGroup(), metadata.getName());
+ schemaExpired.add(schemaKey);
+ } catch (BanyanDBException e) {
+ throw new RuntimeException(e);
Review Comment:
Replace to log warning messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hailin0 commented on a diff in pull request #47: [E2E Testing] Publish customize oap image
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327351312
##########
src/main/proto/banyandb/v1/banyandb-stream.proto:
##########
@@ -84,13 +84,22 @@ message ElementValue {
}
message WriteRequest {
- // the metadata is only required in the first write.
+ // the metadata is required.
common.v1.Metadata metadata = 1 [(validate.rules).message.required = true];
// the element is required.
ElementValue element = 2 [(validate.rules).message.required = true];
+ // the message_id is required.
+ uint64 message_id = 3 [(validate.rules).uint64.gt = 0];
}
-message WriteResponse {}
+message WriteResponse {
+ // the message_id from request.
+ uint64 message_id = 1 [(validate.rules).uint64.gt = 0];
+ // status indicates the request processing result
+ model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
+ // the metadata from request when request fails
+ common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
Review Comment:
You're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #47: [E2E Testing] Publish customize oap image
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1711867839
@hanahmily This is very tricky. Is this acceptable?
This is a one time work now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org