You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2015/11/03 11:09:36 UTC
[GitHub] activemq-artemis pull request: Spelling fixes
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/228
Spelling fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis spelling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #228
----
commit 0e94a694dbe52b6456144de9982177671c71f21a
Author: Ville Skyttä <vi...@iki.fi>
Date: 2015-11-03T10:08:59Z
Spelling fixes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Spelling fixes
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/228#issuecomment-153434306
I use https://github.com/lyda/misspell-check every now and then on various projects when I'm bored :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Spelling fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/228#issuecomment-153379123
@scop how do you find those? manual inspection or you use any tools? you seem pretty good at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: License stuff
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: License stuff
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/228#discussion_r29716501
--- Diff: examples/core/vertx-connector/pom.xml ---
@@ -32,8 +32,10 @@ under the License.
<name>ActiveMQ Artemis Vert.x Example</name>
<properties>
+ <activemq.basedir>${project.basedir}/../../..</activemq.basedir>
--- End diff --
I'm pretty sure this will be broken under the distribution.. can you try running this after building the distribution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Spelling fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---