You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "adamreeve (via GitHub)" <gi...@apache.org> on 2024/06/17 02:56:50 UTC
[PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
adamreeve opened a new pull request, #42172:
URL: https://github.com/apache/arrow/pull/42172
### Rationale for this change
See #42170
### What changes are included in this PR?
Updates the expected output displayed in the docstring of the `float16` function.
It looks like these tests are only run using the latest numpy, so I don't think there's a need to make them work with older numpy too?
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #42172:
URL: https://github.com/apache/arrow/pull/42172#issuecomment-2174936577
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 50f1ed606072f0b746d6447d5bb9d93197f94bb3.
There were 2 benchmark results indicating a performance regression:
- Commit Run on `ec2-r5-4xlarge-us-east-2` at [2024-06-17 22:13:49Z](https://conbench.ursa.dev/compare/runs/cbc25814b6da4fd5a955b0d6b24ac0db...d83cdcb53c4c47e8aec29dc0d6e032bf/)
- [`partitioned-dataset-filter` (R) with dataset=dataset-taxi-parquet, language=R, query=vignette](https://conbench.ursa.dev/compare/benchmarks/06670cf025187c7780000d7a915a893f...06670d1d91b07f358000b5977d53c2e5)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-03, scale_factor=10](https://conbench.ursa.dev/compare/benchmarks/06670d44586f73c28000a92d20544f6f...06670d52e46f751a8000aecf0c6b0f04)
The [full Conbench report](https://github.com/apache/arrow/runs/26347829024) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on PR #42172:
URL: https://github.com/apache/arrow/pull/42172#issuecomment-2174358519
:+1: the normal Python tests should definitely run against numpy 1 and 2. It looks like these doctests are currently only run by this one GitHub actions job that uses the "conda-python-docs" image in docker-compose.yml, which sets the PYTEST_ARGS environment variable to `--doctest-modules --doctest-cython`. I'm not sure it's worth the extra test time and hassle to also run these doctests with numpy 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin merged PR #42172:
URL: https://github.com/apache/arrow/pull/42172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #42172:
URL: https://github.com/apache/arrow/pull/42172#issuecomment-2175430601
Thanks @adamreeve!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42172:
URL: https://github.com/apache/arrow/pull/42172#issuecomment-2172081264
:warning: GitHub issue #42170 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #42172:
URL: https://github.com/apache/arrow/pull/42172#issuecomment-2173988666
Hey @adamreeve, thanks for the fix! It would be nice to add a CI job for Numpy 1.X first. I think we can get that setup pretty quick and then we can rerun the CI jobs here. Supporting Numpy 1 and 2 will give users a chance to upgrade on their own timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42170: [Python][CI] Update expected output for numpy 2.0.0 [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #42172:
URL: https://github.com/apache/arrow/pull/42172#issuecomment-2174473390
+1 I agree. I was thinking of integration tests that run nightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org