You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/19 05:13:39 UTC

[GitHub] [trafficserver] maskit commented on a change in pull request #7015: Server Name API

maskit commented on a change in pull request #7015:
URL: https://github.com/apache/trafficserver/pull/7015#discussion_r456861114



##########
File path: src/traffic_server/InkAPI.cc
##########
@@ -6563,6 +6563,15 @@ TSVConnSslCurveGet(TSVConn sslp)
   return ssl_vc ? ssl_vc->getSSLCurve() : nullptr;
 }
 
+const char *
+TSVConnSslServerNameGet(TSVConn sslp)
+{
+  NetVConnection *vc        = reinterpret_cast<NetVConnection *>(sslp);
+  SSLNetVConnection *ssl_vc = dynamic_cast<SSLNetVConnection *>(vc);

Review comment:
       We don't need this cast since `get_server_name` is defined in NetVConnection, and UnixNetVC returns `nullptr`. QUICNetVC currently returns `nullptr` and will return a server name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org