You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "miland-db (via GitHub)" <gi...@apache.org> on 2024/08/14 11:48:46 UTC
[PR] [SQL] Remove unnecessary asserts from loop iterators [spark]
miland-db opened a new pull request, #47757:
URL: https://github.com/apache/spark/pull/47757
### What changes were proposed in this pull request?
Remove unnecessary checks in the code to make it cleaner.
### Why are the changes needed?
We are sure that `condition` is `SingleStatementExec` and if `assert(curr.get.isInstanceOf[SingleStatementExec])` passes we are still not sure if everything is working correctly. If it fails, we are sure something is wrong, but then it represents the bug in our `iterator` code and should be caught by different unit tests .
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Remove unnecessary asserts from loop iterators [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #47757: [MINOR][SQL] Remove unnecessary asserts from loop iterators
URL: https://github.com/apache/spark/pull/47757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org