You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/15 19:24:26 UTC
[GitHub] [tvm] jwfromm opened a new pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
jwfromm opened a new pull request #7115:
URL: https://github.com/apache/tvm/pull/7115
Onnx has shapes associated with each input in the graph. In many cases, there is no need for users to specify those shapes since we can simply pull them out. In the onnx importer today, however, an error is thrown whenever shapes aren't explicitly provided. This PR changes that behavior and should make the importer much more user friendly. If an input shape can be extracted and is static, it does not need to be passed in as a shape dictionary. If there are unknown shapes, the importer will raise a warning but continue assuming they're dynamic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7115:
URL: https://github.com/apache/tvm/pull/7115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745516694
Hey this looks similar to #7055. Could you also review that PR to see how should we proceed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] dlexplorer commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
dlexplorer commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745562909
> @dlexplorer are you ok with closing your PR and getting this one merged instead?
I verified problematic networks with this PR and they are converted successfully. Agree to close my PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745678926
Seems like we might have hit a flaky cudnn test. I'll try rebasing and recommitting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745519581
@comaniac thanks for pointing that out, you're right that there's a lot of overlap. I looked over #7055 and think that the implementation in this PR is cleaner and probably the one we want to merge. I added the removal of shape_dict in the tvmc frontend converter as well to make sure there's feature parity for both implementations. @dlexplorer are you ok with closing your PR and getting this one merged instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] dlexplorer commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
dlexplorer commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745768280
it may sense to remove shape init from this script as well: https://github.com/dlexplorer/tvm/blob/main/apps/wasm-standalone/wasm-graph/tools/build_graph_lib.py#L32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745550031
@mbrookhart can you also weigh in on this implementation vs that in #7055?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] dlexplorer edited a comment on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
dlexplorer edited a comment on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745768280
it may sense to remove shape init from this script as well: https://github.com/apache/tvm/blob/main/apps/wasm-standalone/wasm-graph/tools/build_graph_lib.py#L32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745512599
@masahi @hogepodge can you guys take a look at this PR? Let me know if there are other default behaviors we should consider.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #7115: [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible.
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #7115:
URL: https://github.com/apache/tvm/pull/7115#issuecomment-745537619
Looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org