You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "nielspardon (via GitHub)" <gi...@apache.org> on 2026/07/22 12:38:18 UTC

[PR] [GLUTEN-12597][CORE] Remove unused vendored Substrait proto files and dead proto-based type derivation [gluten]

nielspardon opened a new pull request, #12598:
URL: https://github.com/apache/gluten/pull/12598

   ## What changes are proposed in this pull request?
   
   Preparatory cleanup for rebasing the vendored Substrait proto onto 0.98.0 (#12597). Removes dead definitions with no functional change:
   
   - **Deletes 4 vendored proto files** that are unused by Gluten and were removed upstream (substrait-io/substrait#952, substrait-io/substrait#940): `capabilities.proto`, `function.proto`, `parameterized_types.proto`, `type_expressions.proto`.
   - **Deletes the orphaned `org.apache.gluten.substrait.derivation` package** (`DerivationExpressionNode`, `DerivationExpressionBuilder`, `BinaryOPNode`, `DerivationFP64TypeNode`) — the sole consumer of `type_expressions.proto`'s `DerivationExpression`. It has no callers in the plan producer, either native backend, or the tests. Upstream expresses output-type derivation via the ANTLR grammar carried in the extension YAMLs, not `DerivationExpression` protos.
   - **Removes the deprecated `Expression.Enum`** message and its `rex_type` oneof field (10), reserving the number and name to match upstream (substrait-io/substrait#1086). `Expression.Enum` is not built by the producer nor parsed by the Velox/ClickHouse backends; enum function arguments use `FunctionArgument.enum` instead.
   
   ## How was this patch tested?
   
   No functional change — pure dead-definition removal. Verified that the vendored proto still compiles (`protoc` descriptor-set generation succeeds with no dangling imports or duplicate field numbers), and confirmed via repo-wide search that no JVM code (`gluten-substrait`, backends) or native code (`cpp/velox`, `cpp-ch/local-engine`) references the removed files, the removed package, or `Expression.Enum`. Covered by the existing JVM and Velox/ClickHouse proto-codegen builds; no new unit test is applicable.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 4.8)
   
   🤖 Generated with AI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-12597][CORE] Remove unused vendored Substrait proto files and dead proto-based type derivation [gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12598:
URL: https://github.com/apache/gluten/pull/12598#issuecomment-5046330996

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-12597][CORE] Remove unused vendored Substrait proto files and dead proto-based type derivation [gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #12598:
URL: https://github.com/apache/gluten/pull/12598


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-12597][CORE] Remove unused vendored Substrait proto files and dead proto-based type derivation [gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12598:
URL: https://github.com/apache/gluten/pull/12598#issuecomment-5046117772

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org