[GitHub] dubeejw opened a new issue #3205: Controller seed nodes should not be required when local bookkeeping is used

[GitBox <gi...@apache.org>]

dubeejw opened a new issue #3205: Controller seed nodes should not be required when local bookkeeping is used
URL: https://github.com/apache/incubator-openwhisk/issues/3205
 
 
   `controllerSeedNodes` should not be a required property as long as `controllerLocalBookkeeping` is enabled. When `controllerLocalBookkeeping` is enabled, `controllerSeedNodes` is never referenced.
   
   From LoadBalancerService.scala:
   
   Makes seed nodes a required property:
   ```
   def requiredProperties =
       kafkaHosts ++
         Map(controllerLocalBookkeeping -> null, controllerSeedNodes -> null)
   ```
   
   Does not reference seed node when local bookkeeping is used:
   ```
   private val loadBalancerData = {
       if (config.controllerLocalBookkeeping) {
         new LocalLoadBalancerData()
       } else {
   
         /** Specify how seed nodes are generated */
         val seedNodesProvider = new StaticSeedNodesProvider(config.controllerSeedNodes, actorSystem.name)
         Cluster(actorSystem).joinSeedNodes(seedNodesProvider.getSeedNodes())
         new DistributedLoadBalancerData()
       }
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services