[jira] [Commented] (KAFKA-907) controller needs to close socket channel to brokers on exception

["Neha Narkhede (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664298#comment-13664298 ] 

Neha Narkhede commented on KAFKA-907:
-------------------------------------

Thanks for the patch. The following if statement is unnecessary since that condition gets checked in the connect() API of BlockingChannel.

    if(!channel.isConnected) {
      channel.connect()
    }

Other than that, +1
                
> controller needs to close socket channel to brokers on exception
> ----------------------------------------------------------------
>
>                 Key: KAFKA-907
>                 URL: https://issues.apache.org/jira/browse/KAFKA-907
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: kafka-907.patch
>
>
> When the controller sends a request to a broker (e.g., leaderAndIsrRequest), it may hit a exception (e.g. SocketTimeException). When this happens, the socket channel needs to be closed and recreated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira