You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/12 00:31:07 UTC
[GitHub] codecov-io edited a comment on issue #4961: Deprecate database
attribute allow_run_sync
codecov-io edited a comment on issue #4961: Deprecate database attribute allow_run_sync
URL: https://github.com/apache/incubator-superset/pull/4961#issuecomment-388889659
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4961?src=pr&el=h1) Report
> Merging [#4961](https://codecov.io/gh/apache/incubator-superset/pull/4961?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/962eb0860c992c1b2af3e2b5b93b2f5a31c15cf9?src=pr&el=desc) will **decrease** coverage by `0.89%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4961?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4961 +/- ##
=========================================
- Coverage 77.99% 77.09% -0.9%
=========================================
Files 46 44 -2
Lines 9312 8633 -679
=========================================
- Hits 7263 6656 -607
+ Misses 2049 1977 -72
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4961?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.85% <ø> (-1.18%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.29% <ø> (-1%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.66% <ø> (+0.44%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.52% <100%> (+1.42%)` | :arrow_up: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `44.06% <0%> (-9.75%)` | :arrow_down: |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `67.64% <0%> (-8.44%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.42% <0%> (-4.71%)` | :arrow_down: |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `14.7% <0%> (-3.61%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.47% <0%> (-2.73%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.49% <0%> (-2.07%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/incubator-superset/pull/4961/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4961?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4961?src=pr&el=footer). Last update [962eb08...1d57188](https://codecov.io/gh/apache/incubator-superset/pull/4961?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org