You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2022/07/04 11:04:29 UTC
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18698
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error
when instantiated
The function template 'CodegenFnPtr<FuncType>::store()' tries to
implicitly cast a function pointer to 'void*', which is a compile time
error. The reason this hasn't come up in the builds is that this
function template is currently not used anywhere, and the function
pointers are stored through the parent class, using
'CodegenFnPtrBase::store()', which takes a 'void*'.
This commit adds the correct explicit cast from function pointer to
'void*' in 'CodegenFnPtr<FuncType>::store()' and adds tests which
instantiate (and test) this function template.
Testing:
- Added tests in llvm-codegen-test.cc that assert that
'CodegenFnPtr<FuncType>::load()' gives back the same function pointer
that we store in the object. One test stores the function pointer as
a 'void*' through 'CodegenFnPtrBase' and the other as a typed
function pointer through 'CodegenFnPtr<FuncType>'.
Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
---
M be/src/codegen/codegen-fn-ptr.h
M be/src/codegen/llvm-codegen-test.cc
2 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/18698/1
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8288/
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 19:02:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8297/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:28:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8288/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 14:21:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10931/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 12:07:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8289/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 08:50:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:28:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error
when instantiated
The function template 'CodegenFnPtr<FuncType>::store()' tries to
implicitly cast a function pointer to 'void*', which is a compile time
error. The reason this hasn't come up in the builds is that this
function template is currently not used anywhere, and the function
pointers are stored through the parent class, using
'CodegenFnPtrBase::store()', which takes a 'void*'.
This commit adds the correct explicit cast from function pointer to
'void*' in 'CodegenFnPtr<FuncType>::store()' and adds tests which
instantiate (and test) this function template.
Testing:
- Added tests in llvm-codegen-test.cc that assert that
'CodegenFnPtr<FuncType>::load()' gives back the same function pointer
that we store in the object. One test stores the function pointer as
a 'void*' through 'CodegenFnPtrBase' and the other as a typed
function pointer through 'CodegenFnPtr<FuncType>'.
Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Reviewed-on: http://gerrit.cloudera.org:8080/18698
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/codegen/codegen-fn-ptr.h
M be/src/codegen/llvm-codegen-test.cc
2 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 1:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8289/
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 13:30:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8295/
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 16:44:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 14:13:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error
when instantiated
The function template 'CodegenFnPtr<FuncType>::store()' tries to
implicitly cast a function pointer to 'void*', which is a compile time
error. The reason this hasn't come up in the builds is that this
function template is currently not used anywhere, and the function
pointers are stored through the parent class, using
'CodegenFnPtrBase::store()', which takes a 'void*'.
This commit adds the correct explicit cast from function pointer to
'void*' in 'CodegenFnPtr<FuncType>::store()' and adds tests which
instantiate (and test) this function template.
Testing:
- Added tests in llvm-codegen-test.cc that assert that
'CodegenFnPtr<FuncType>::load()' gives back the same function pointer
that we store in the object. One test stores the function pointer as
a 'void*' through 'CodegenFnPtrBase' and the other as a typed
function pointer through 'CodegenFnPtr<FuncType>'.
Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
---
M be/src/codegen/codegen-fn-ptr.h
M be/src/codegen/llvm-codegen-test.cc
2 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/18698/2
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8295/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 11:49:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 3: Code-Review+2
Seems the GVO job failed on known flaky tests. Restarting the job.
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:27:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 1: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 12:25:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11412: CodegenFnPtr::store() has a compile time error when instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18698 )
Change subject: IMPALA-11412: CodegenFnPtr<FuncType>::store() has a compile time error when instantiated
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10918/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86c78b6237630403db6ca14a3d3e1cffe0e477db
Gerrit-Change-Number: 18698
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 11:15:35 +0000
Gerrit-HasComments: No