You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by Kasper Sørensen <i....@gmail.com> on 2014/08/12 20:38:31 UTC

Review Request 24613: Fix for issue with blank/empty strings in aggregate functions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24613/
-----------------------------------------------------------

Review request for MetaModel.


Repository: metamodel


Description
-------

Proposed fix for the issue reported by Vinu Agnihotri. Empty/blank strings in input to aggregate functions throw exceptions.


Diffs
-----

  core/src/main/java/org/apache/metamodel/query/AverageAggregateBuilder.java 44a2341 
  core/src/main/java/org/apache/metamodel/query/SumAggregateBuilder.java 93b2676 
  core/src/main/java/org/apache/metamodel/util/AbstractNumberAggregateBuilder.java PRE-CREATION 
  core/src/main/java/org/apache/metamodel/util/AggregateBuilder.java 477c2d4 
  core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java 72cd8c2 

Diff: https://reviews.apache.org/r/24613/diff/


Testing
-------

Unittest examples added


Thanks,

Kasper Sørensen